Re: [ovs-dev] [PATCH] ofproto-dpif-upcall: Mirror packets that are modified

On Tue, Feb 21, 2023 at 10:11:27AM -0500, Mike Pattrick wrote: > On Tue, Feb 21, 2023 at 5:35 AM Simon Horman > wrote: > > > > On Thu, Feb 16, 2023 at 03:05:08PM -0500, Mike Pattrick wrote: > > > Currently OVS keeps track of which mirrors that each packet has been > > > sent to for the purpose

Re: [ovs-dev] [PATCH] ofproto-dpif-upcall: Mirror packets that are modified

On Tue, Feb 21, 2023 at 5:35 AM Simon Horman wrote: > > On Thu, Feb 16, 2023 at 03:05:08PM -0500, Mike Pattrick wrote: > > Currently OVS keeps track of which mirrors that each packet has been > > sent to for the purpose of deduplication. However, this doesn't consider > > that openflow rules can

Re: [ovs-dev] [PATCH] ofproto-dpif-upcall: Mirror packets that are modified

On Thu, Feb 16, 2023 at 03:05:08PM -0500, Mike Pattrick wrote: > Currently OVS keeps track of which mirrors that each packet has been > sent to for the purpose of deduplication. However, this doesn't consider > that openflow rules can make significant changes to packets after > ingress. > > For

Re: [ovs-dev] [PATCH] ofproto-dpif-upcall: Mirror packets that are modified

Hi Mike, Thanks for the patch!. I took your patch and tried running the OVN unit test for the 'both' direction packets mirroring check using the ovsmirrortest.diff attached in the BZ (2155579 ) It passed with your patch. Thanks & Regards,

[ovs-dev] [PATCH] ofproto-dpif-upcall: Mirror packets that are modified

Currently OVS keeps track of which mirrors that each packet has been sent to for the purpose of deduplication. However, this doesn't consider that openflow rules can make significant changes to packets after ingress. For example, OVN can create OpenFlow rules that turn an echo request into an