Re: [ovs-dev] [PATCH] ofproto-dpif-xlate: Terminate native tunnels only on ports with IP addresses.

2021-11-19 Thread Ilya Maximets
On 11/17/21 15:22, Mike Pattrick wrote: > Looks good to me. > > Acked-by: Mike Pattrick Thanks! I folded the test change in and applied. Best regards, Ilya Maximets. > > > On Mon, Nov 15, 2021 at 1:08 PM Ilya Maximets wrote: >> >> On 11/15/21 18:28, Mike Pattrick wrote: >>> Hello Ilya,

Re: [ovs-dev] [PATCH] ofproto-dpif-xlate: Terminate native tunnels only on ports with IP addresses.

2021-11-17 Thread Mike Pattrick
Looks good to me. Acked-by: Mike Pattrick On Mon, Nov 15, 2021 at 1:08 PM Ilya Maximets wrote: > > On 11/15/21 18:28, Mike Pattrick wrote: > > Hello Ilya, > > > > For some reason, the included test fails for me when I try to run it. > > The diff is: > > > > ./tunnel-push-pop.at:751: tail -2

Re: [ovs-dev] [PATCH] ofproto-dpif-xlate: Terminate native tunnels only on ports with IP addresses.

2021-11-15 Thread Ilya Maximets
On 11/15/21 18:28, Mike Pattrick wrote: > Hello Ilya, > > For some reason, the included test fails for me when I try to run it. > The diff is: > > ./tunnel-push-pop.at:751: tail -2 stdout > --- -2021-11-15 12:09:05.838890065 -0500 > +++ /root/ovs/tests/testsuite.dir/at-groups/782/stdout

Re: [ovs-dev] [PATCH] ofproto-dpif-xlate: Terminate native tunnels only on ports with IP addresses.

2021-11-15 Thread Mike Pattrick
Hello Ilya, For some reason, the included test fails for me when I try to run it. The diff is: ./tunnel-push-pop.at:751: tail -2 stdout --- -2021-11-15 12:09:05.838890065 -0500 +++ /root/ovs/tests/testsuite.dir/at-groups/782/stdout2021-11-15 12:09:05.836652743 -0500 @@ -1,3 +1,3 @@

[ovs-dev] [PATCH] ofproto-dpif-xlate: Terminate native tunnels only on ports with IP addresses.

2021-11-01 Thread Ilya Maximets
Commit dc0bd12f5b04 removed restriction that tunnel endpoint must be a bridge port. So, currently OVS has to check if the native tunnel needs to be terminated regardless of the output port. Unfortunately, there is a side effect: tnl_port_map_lookup() always adds at least 'dl_dst' match to the