Re: [ovs-dev] [PATCH] ovn: Fix encoding of large logical output ports for STT.

Thanks for the review! I applied this to master, branch-2.7, and branch-2.6. On Mon, May 29, 2017 at 12:47:07PM +0200, Miguel Angel Ajo Pelayo wrote: > Acked-By: Miguel Angel Ajo > > $ cat test.c > #include > #include > > void main(void) { > >

Re: [ovs-dev] [PATCH] ovn: Fix encoding of large logical output ports for STT.

Acked-By: Miguel Angel Ajo $ cat test.c #include #include void main(void) { printf("uint16_t<<24=%Lx\n", ((uint16_t)0xf123)<<24); printf("uint64_t<<24=%Lx\n", ((uint64_t)0xf123)<<24); } linux: vagrant@gw1 in ~/ovs on $ ./test uint16_t<<24=2300

[ovs-dev] [PATCH] ovn: Fix encoding of large logical output ports for STT.

put_encapsulation() is meant to load the logical output port into bits 24 to 40 of the tunnel ID metadata field, but 'outport << 24' did not have that effect because outport has type uint16_t. This fixes the problem. Found by Coverity. Reported-at: