Re: [ovs-dev] [PATCH] ovn-nbctl, ovn-sbctl, ovs-vsctl: Remove gratuitous NULL checks.

2017-05-30 Thread Ben Pfaff
Thank you! I applied this to master. On Mon, May 29, 2017 at 01:32:21PM +0200, Miguel Angel Ajo Pelayo wrote: > Acked-by: Miguel Angel Ajo > > On Sat, May 27, 2017 at 5:44 AM, Ben Pfaff wrote: > > > These functions all set txn and do not un-set it within

Re: [ovs-dev] [PATCH] ovn-nbctl, ovn-sbctl, ovs-vsctl: Remove gratuitous NULL checks.

2017-05-29 Thread Miguel Angel Ajo Pelayo
Acked-by: Miguel Angel Ajo On Sat, May 27, 2017 at 5:44 AM, Ben Pfaff wrote: > These functions all set txn and do not un-set it within their main > command execution function, so it's gratuitous to check it along this path. > > Found by Coverity. > >

[ovs-dev] [PATCH] ovn-nbctl, ovn-sbctl, ovs-vsctl: Remove gratuitous NULL checks.

2017-05-26 Thread Ben Pfaff
These functions all set txn and do not un-set it within their main command execution function, so it's gratuitous to check it along this path. Found by Coverity. Reported-at: https://scan3.coverity.com/reports.htm#v16889/p10449/fileInstanceId=14763082=4305338=180417 Signed-off-by: Ben Pfaff