Re: [ovs-dev] [PATCH] ovn-nbctl: Fix compilation warnings.

2018-07-16 Thread Darrell Ball
This occurs with O3 in gcc 6 It was previously fixed with commit bfd2c0eccedf024e2c2baaf8f43ad4d97480ea0d(ovn-nbctl: Always initialize output arguments in *_by_name_or_uuid().) On Sat, Jul 14, 2018 at 1:05 PM, Justin Pettit wrote: > Interesting. I don't see those errors with gcc 7.3.0. I

Re: [ovs-dev] [PATCH] ovn-nbctl: Fix compilation warnings.

2018-07-14 Thread Justin Pettit
Interesting. I don't see those errors with gcc 7.3.0. I went ahead and applied the patch to master and backported it to branch-2.9, since it fixes a problem that you're seeing. Thanks, --Justin > On Jul 10, 2018, at 11:46 AM, Ian Stokes wrote: > > This commit fixes 'maybe-uninitialized'

Re: [ovs-dev] [PATCH] ovn-nbctl: Fix compilation warnings.

2018-07-11 Thread Ben Pfaff
On Wed, Jul 11, 2018 at 09:13:15AM +, Stokes, Ian wrote: > > On Tue, Jul 10, 2018 at 07:46:55PM +0100, Ian Stokes wrote: > > > This commit fixes 'maybe-uninitialized' warnings for pointers in > > > various functions in ovn-nbctl when compiling with gcc 6.3.1 and - > > Werror. > > > Pointers to

Re: [ovs-dev] [PATCH] ovn-nbctl: Fix compilation warnings.

2018-07-11 Thread Stokes, Ian
> On Tue, Jul 10, 2018 at 07:46:55PM +0100, Ian Stokes wrote: > > This commit fixes 'maybe-uninitialized' warnings for pointers in > > various functions in ovn-nbctl when compiling with gcc 6.3.1 and - > Werror. > > Pointers to structs nbrec_logical_switch, nbrec_logical_switch_port, > >

Re: [ovs-dev] [PATCH] ovn-nbctl: Fix compilation warnings.

2018-07-10 Thread Ben Pfaff
On Tue, Jul 10, 2018 at 07:46:55PM +0100, Ian Stokes wrote: > This commit fixes 'maybe-uninitialized' warnings for pointers in various > functions in ovn-nbctl when compiling with gcc 6.3.1 and -Werror. > Pointers to structs nbrec_logical_switch, nbrec_logical_switch_port, > nbrec_logical_router

[ovs-dev] [PATCH] ovn-nbctl: Fix compilation warnings.

2018-07-10 Thread Ian Stokes
This commit fixes 'maybe-uninitialized' warnings for pointers in various functions in ovn-nbctl when compiling with gcc 6.3.1 and -Werror. Pointers to structs nbrec_logical_switch, nbrec_logical_switch_port, nbrec_logical_router and nbrec_logical_router_port are now initialized to NULL where