Re: [ovs-dev] [PATCH] system-common-macros: Fix conntrack matching.

2024-01-22 Thread Eelco Chaudron
On 22 Jan 2024, at 21:51, Ilya Maximets wrote: > On 1/19/24 14:01, Eelco Chaudron wrote: >> >> >> On 19 Jan 2024, at 13:53, David Marchand wrote: >> >>> On Fri, Jan 19, 2024 at 1:49 PM Ilya Maximets wrote: On 1/18/24 14:00, David Marchand wrote: > Seen in GHA recently. > Unit

Re: [ovs-dev] [PATCH] system-common-macros: Fix conntrack matching.

2024-01-22 Thread Ilya Maximets
On 1/19/24 14:01, Eelco Chaudron wrote: > > > On 19 Jan 2024, at 13:53, David Marchand wrote: > >> On Fri, Jan 19, 2024 at 1:49 PM Ilya Maximets wrote: >>> >>> On 1/18/24 14:00, David Marchand wrote: Seen in GHA recently. Unit tests are checking conntracks relating to a destination ip

Re: [ovs-dev] [PATCH] system-common-macros: Fix conntrack matching.

2024-01-19 Thread Simon Horman
On Fri, Jan 19, 2024 at 01:40:03PM +0100, David Marchand wrote: > On Fri, Jan 19, 2024 at 1:20 PM Simon Horman wrote: > > > > On Thu, Jan 18, 2024 at 02:00:18PM +0100, David Marchand wrote: > > > Seen in GHA recently. > > > Unit tests are checking conntracks relating to a destination ip address >

Re: [ovs-dev] [PATCH] system-common-macros: Fix conntrack matching.

2024-01-19 Thread Eelco Chaudron
On 19 Jan 2024, at 13:53, David Marchand wrote: > On Fri, Jan 19, 2024 at 1:49 PM Ilya Maximets wrote: >> >> On 1/18/24 14:00, David Marchand wrote: >>> Seen in GHA recently. >>> Unit tests are checking conntracks relating to a destination ip address >>> but the FORMAT_CT macro is not strict en

Re: [ovs-dev] [PATCH] system-common-macros: Fix conntrack matching.

2024-01-19 Thread Eelco Chaudron
On 19 Jan 2024, at 13:49, Ilya Maximets wrote: > On 1/18/24 14:00, David Marchand wrote: >> Seen in GHA recently. >> Unit tests are checking conntracks relating to a destination ip address >> but the FORMAT_CT macro is not strict enough and would match unrelated >> conntracks too. >> >> Example

Re: [ovs-dev] [PATCH] system-common-macros: Fix conntrack matching.

2024-01-19 Thread David Marchand
On Fri, Jan 19, 2024 at 1:49 PM Ilya Maximets wrote: > > On 1/18/24 14:00, David Marchand wrote: > > Seen in GHA recently. > > Unit tests are checking conntracks relating to a destination ip address > > but the FORMAT_CT macro is not strict enough and would match unrelated > > conntracks too. > >

Re: [ovs-dev] [PATCH] system-common-macros: Fix conntrack matching.

2024-01-19 Thread Ilya Maximets
On 1/18/24 14:00, David Marchand wrote: > Seen in GHA recently. > Unit tests are checking conntracks relating to a destination ip address > but the FORMAT_CT macro is not strict enough and would match unrelated > conntracks too. > > Example: > 148. system-traffic.at:6432: testing conntrack - DNAT

Re: [ovs-dev] [PATCH] system-common-macros: Fix conntrack matching.

2024-01-19 Thread David Marchand
On Fri, Jan 19, 2024 at 1:20 PM Simon Horman wrote: > > On Thu, Jan 18, 2024 at 02:00:18PM +0100, David Marchand wrote: > > Seen in GHA recently. > > Unit tests are checking conntracks relating to a destination ip address > > but the FORMAT_CT macro is not strict enough and would match unrelated >

Re: [ovs-dev] [PATCH] system-common-macros: Fix conntrack matching.

2024-01-19 Thread Simon Horman
On Thu, Jan 18, 2024 at 02:00:18PM +0100, David Marchand wrote: > Seen in GHA recently. > Unit tests are checking conntracks relating to a destination ip address > but the FORMAT_CT macro is not strict enough and would match unrelated > conntracks too. > > Example: > 148. system-traffic.at:6432: t

[ovs-dev] [PATCH] system-common-macros: Fix conntrack matching.

2024-01-18 Thread David Marchand
Seen in GHA recently. Unit tests are checking conntracks relating to a destination ip address but the FORMAT_CT macro is not strict enough and would match unrelated conntracks too. Example: 148. system-traffic.at:6432: testing conntrack - DNAT with additional SNAT ... [...] ./system-traffi