Re: [ovs-dev] [PATCH] tc: Add TCA_KIND flower to delete and get operation to avoid rtnl_lock().

2023-01-27 Thread Eelco Chaudron
On 27 Jan 2023, at 11:36, Ilya Maximets wrote: > On 1/26/23 13:33, Marcelo Ricardo Leitner wrote: >> On Thu, Jan 26, 2023 at 04:23:39AM -0800, Marcelo Ricardo Leitner wrote: >>> +Cc Chris, Paul and Vlad. >>> >>> On Thu, Jan 26, 2023 at 11:08:02AM +0100, Eelco Chaudron wrote: A long long

Re: [ovs-dev] [PATCH] tc: Add TCA_KIND flower to delete and get operation to avoid rtnl_lock().

2023-01-27 Thread Ilya Maximets
On 1/26/23 13:33, Marcelo Ricardo Leitner wrote: > On Thu, Jan 26, 2023 at 04:23:39AM -0800, Marcelo Ricardo Leitner wrote: >> +Cc Chris, Paul and Vlad. >> >> On Thu, Jan 26, 2023 at 11:08:02AM +0100, Eelco Chaudron wrote: >>> A long long time ago, an effort was made to make tc flower >>>

Re: [ovs-dev] [PATCH] tc: Add TCA_KIND flower to delete and get operation to avoid rtnl_lock().

2023-01-26 Thread Vlad Buslov via dev
+Cc Roi On Thu 26 Jan 2023 at 04:33, Marcelo Ricardo Leitner wrote: > On Thu, Jan 26, 2023 at 04:23:39AM -0800, Marcelo Ricardo Leitner wrote: >> +Cc Chris, Paul and Vlad. >> >> On Thu, Jan 26, 2023 at 11:08:02AM +0100, Eelco Chaudron wrote: >> > A long long time ago, an effort was made to make

Re: [ovs-dev] [PATCH] tc: Add TCA_KIND flower to delete and get operation to avoid rtnl_lock().

2023-01-26 Thread Marcelo Ricardo Leitner
On Thu, Jan 26, 2023 at 04:23:39AM -0800, Marcelo Ricardo Leitner wrote: > +Cc Chris, Paul and Vlad. > > On Thu, Jan 26, 2023 at 11:08:02AM +0100, Eelco Chaudron wrote: > > A long long time ago, an effort was made to make tc flower > > rtnl_lock() free. However, on the OVS part we forgot to add >

Re: [ovs-dev] [PATCH] tc: Add TCA_KIND flower to delete and get operation to avoid rtnl_lock().

2023-01-26 Thread Marcelo Ricardo Leitner
+Cc Chris, Paul and Vlad. On Thu, Jan 26, 2023 at 11:08:02AM +0100, Eelco Chaudron wrote: > A long long time ago, an effort was made to make tc flower > rtnl_lock() free. However, on the OVS part we forgot to add > the TCA_KIND "flower" attribute, which tell the kernel to skip > the lock. This

[ovs-dev] [PATCH] tc: Add TCA_KIND flower to delete and get operation to avoid rtnl_lock().

2023-01-26 Thread Eelco Chaudron
A long long time ago, an effort was made to make tc flower rtnl_lock() free. However, on the OVS part we forgot to add the TCA_KIND "flower" attribute, which tell the kernel to skip the lock. This patch corrects this by adding the attribute for the delete and get operations. Signed-off-by: Eelco