Re: [ovs-dev] [PATCH] tc: Fix stats dump when using same meter table

2022-09-14 Thread Simon Horman
On Tue, Sep 13, 2022 at 01:47:31PM +0200, Simon Horman wrote: > On Tue, Sep 13, 2022 at 12:41:33PM +0200, Ilya Maximets wrote: > > On 9/13/22 09:51, Simon Horman wrote: > > > On Mon, Sep 12, 2022 at 03:02:06PM +0200, Eelco Chaudron wrote: ... > > > Thanks Eelco, > > > > > > I've made the change

Re: [ovs-dev] [PATCH] tc: Fix stats dump when using same meter table

2022-09-13 Thread Simon Horman
On Tue, Sep 13, 2022 at 12:41:33PM +0200, Ilya Maximets wrote: > On 9/13/22 09:51, Simon Horman wrote: > > On Mon, Sep 12, 2022 at 03:02:06PM +0200, Eelco Chaudron wrote: > >> > >> > >> On 7 Sep 2022, at 11:36, Simon Horman wrote: > >> > >>> From: Tianyu Yuan > >>> > >>> When we apply meter police

Re: [ovs-dev] [PATCH] tc: Fix stats dump when using same meter table

2022-09-13 Thread Ilya Maximets
On 9/13/22 09:51, Simon Horman wrote: > On Mon, Sep 12, 2022 at 03:02:06PM +0200, Eelco Chaudron wrote: >> >> >> On 7 Sep 2022, at 11:36, Simon Horman wrote: >> >>> From: Tianyu Yuan >>> >>> When we apply meter police on both directions of TCP traffic, the >>> dumped stats is shown same (as shown

Re: [ovs-dev] [PATCH] tc: Fix stats dump when using same meter table

2022-09-13 Thread Simon Horman
On Mon, Sep 12, 2022 at 03:02:06PM +0200, Eelco Chaudron wrote: > > > On 7 Sep 2022, at 11:36, Simon Horman wrote: > > > From: Tianyu Yuan > > > > When we apply meter police on both directions of TCP traffic, the > > dumped stats is shown same (as shown below). This issue is introduced > > by m

Re: [ovs-dev] [PATCH] tc: Fix stats dump when using same meter table

2022-09-12 Thread Eelco Chaudron
On 7 Sep 2022, at 11:36, Simon Horman wrote: > From: Tianyu Yuan > > When we apply meter police on both directions of TCP traffic, the > dumped stats is shown same (as shown below). This issue is introduced > by modifying the stats update strategy. > > ...,in_port(6),eth(),eth_type(0x0800),ipv

Re: [ovs-dev] [PATCH] tc: Fix stats dump when using same meter table

2022-09-07 Thread 0-day Robot
Bleep bloop. Greetings Simon Horman, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: WARNING: Unexpected sign-offs from developers who are not authors or co-authors or committers:

[ovs-dev] [PATCH] tc: Fix stats dump when using same meter table

2022-09-07 Thread Simon Horman
From: Tianyu Yuan When we apply meter police on both directions of TCP traffic, the dumped stats is shown same (as shown below). This issue is introduced by modifying the stats update strategy. ...,in_port(6),eth(),eth_type(0x0800),ipv4(frag=no), packets:1488557, bytes:2089059644, used:0.040s, a

Re: [ovs-dev] [PATCH] tc: Fix stats dump when using same meter table

2022-08-23 Thread Eelco Chaudron
On 15 Aug 2022, at 11:49, Simon Horman wrote: > From: Tianyu Yuan > > When we apply meter police on both directions of TCP traffic, the > dumped stats is shown same (as shown below). This issue is introduced > by modifying the stats update strategy. > > ...,in_port(6),eth(),eth_type(0x0800),ip

Re: [ovs-dev] [PATCH] tc: Fix stats dump when using same meter table

2022-08-15 Thread 0-day Robot
References: <20220815094916.301466-1-simon.hor...@corigine.com> Bleep bloop. Greetings Simon Horman, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: WARNING: Unexpected sign-of

[ovs-dev] [PATCH] tc: Fix stats dump when using same meter table

2022-08-15 Thread Simon Horman
From: Tianyu Yuan When we apply meter police on both directions of TCP traffic, the dumped stats is shown same (as shown below). This issue is introduced by modifying the stats update strategy. ...,in_port(6),eth(),eth_type(0x0800),ipv4(frag=no), packets:1488557, bytes:2089059644, used:0.040s, a