Re: [ovs-dev] [PATCH] util: Document and rely on ovs_assert() always evaluating its argument.

2018-02-01 Thread Ben Pfaff
Thank you for the review I applied this to master. On Wed, Jan 31, 2018 at 02:57:01PM -0800, Yifeng Sun wrote: > Thanks, looks good to me. > > Reviewed-by: Yifeng Sun > > On Wed, Jan 31, 2018 at 11:23 AM, Ben Pfaff wrote: > > > The ovs_assert() macro always evaluates its argument, even when

Re: [ovs-dev] [PATCH] util: Document and rely on ovs_assert() always evaluating its argument.

2018-01-31 Thread Yifeng Sun
Thanks, looks good to me. Reviewed-by: Yifeng Sun On Wed, Jan 31, 2018 at 11:23 AM, Ben Pfaff wrote: > The ovs_assert() macro always evaluates its argument, even when NDEBUG is > defined so that failure is ignored. This behavior wasn't documented, and > thus a lot of code didn't rely on it.

[ovs-dev] [PATCH] util: Document and rely on ovs_assert() always evaluating its argument.

2018-01-31 Thread Ben Pfaff
The ovs_assert() macro always evaluates its argument, even when NDEBUG is defined so that failure is ignored. This behavior wasn't documented, and thus a lot of code didn't rely on it. This commit documents the behavior and simplifies bits of code that heretofore didn't rely on it. Signed-off-by