Re: [ovs-dev] [PATCH] util: Use lookup table to optimize hexit_value().

On Mon, Feb 05, 2018 at 05:40:28PM +0100, Jakub Sitnicki wrote: > On Mon, Feb 05, 2018 at 04:25 PM GMT, Ben Pfaff wrote: > > On Mon, Feb 05, 2018 at 05:03:13PM +0100, Jakub Sitnicki wrote: > >> > >> It caught my attention that the contract with hexit_value() callers has > >> changed. Previously

Re: [ovs-dev] [PATCH] util: Use lookup table to optimize hexit_value().

On Mon, Feb 05, 2018 at 04:25 PM GMT, Ben Pfaff wrote: > On Mon, Feb 05, 2018 at 05:03:13PM +0100, Jakub Sitnicki wrote: >> >> It caught my attention that the contract with hexit_value() callers has >> changed. Previously we had a catch-all clause for out-of-range values. >> Now there will be an

Re: [ovs-dev] [PATCH] util: Use lookup table to optimize hexit_value().

On Mon, Feb 05, 2018 at 05:03:13PM +0100, Jakub Sitnicki wrote: > Hi Ben, > > On Fri, Feb 02, 2018 at 11:16 PM GMT, Ben Pfaff wrote: > > Daniel Alvarez Sanchez reported a significant overall speedup in ovn-northd > > due to a similar patch. > > > > Reported-by: Daniel Alvarez Sanchez

Re: [ovs-dev] [PATCH] util: Use lookup table to optimize hexit_value().

Hi Ben, On Fri, Feb 02, 2018 at 11:16 PM GMT, Ben Pfaff wrote: > Daniel Alvarez Sanchez reported a significant overall speedup in ovn-northd > due to a similar patch. > > Reported-by: Daniel Alvarez Sanchez > Reported-at: >

Re: [ovs-dev] [PATCH] util: Use lookup table to optimize hexit_value().

Thanks for the patch, Ben. Looks good to me. Acked-by: Daniel Alvarez On Sat, Feb 3, 2018 at 12:16 AM, Ben Pfaff wrote: > Daniel Alvarez Sanchez reported a significant overall speedup in ovn-northd > due to a similar patch. > > Reported-by: Daniel Alvarez

Re: [ovs-dev] [PATCH] util: Use lookup table to optimize hexit_value().

Looks good to me, thanks. Reviewed-by: Yifeng Sun On Fri, Feb 2, 2018 at 3:16 PM, Ben Pfaff wrote: > Daniel Alvarez Sanchez reported a significant overall speedup in ovn-northd > due to a similar patch. > > Reported-by: Daniel Alvarez Sanchez

[ovs-dev] [PATCH] util: Use lookup table to optimize hexit_value().

Daniel Alvarez Sanchez reported a significant overall speedup in ovn-northd due to a similar patch. Reported-by: Daniel Alvarez Sanchez Reported-at: https://mail.openvswitch.org/pipermail/ovs-discuss/2018-February/046120.html Signed-off-by: Ben Pfaff ---