Re: [ovs-dev] [PATCH 01/15] log: Add async commit support.

2018-01-11 Thread Yifeng Sun
After further study, I understand the "seq" code and think it is well-designed. Thank you for this patch and the previous reply. This patch looks good to me. Reviewed-by: Yifeng Sun On Wed, Jan 10, 2018 at 4:21 PM, Ben Pfaff wrote: > Thanks for the review. > > The "seq" code introduces kind o

Re: [ovs-dev] [PATCH 01/15] log: Add async commit support.

2018-01-10 Thread Ben Pfaff
Thanks for the review. The "seq" code introduces kind of a weird concept. I might have invented it, not sure, but it's probably some kind of distortion of a more standard idea. I'd like it to be easy for people to understand. Are there any questions that I could help to answer? Maybe I could an

Re: [ovs-dev] [PATCH 01/15] log: Add async commit support.

2018-01-10 Thread Yifeng Sun
I read through lib/seq.c to learn how this patch works. Looks good to me, but I feel not very confident. Reviewed-by: Yifeng Sun On Sun, Dec 31, 2017 at 9:16 PM, Ben Pfaff wrote: > The OVSDB log code has always had the ability to commit the log to disk and > wait for the commit to finish. Thi

[ovs-dev] [PATCH 01/15] log: Add async commit support.

2017-12-31 Thread Ben Pfaff
The OVSDB log code has always had the ability to commit the log to disk and wait for the commit to finish. This patch introduces a new feature that allows the client to start a commit in the background and then to determine asynchronously that the commit has completed. This will be especially use