Re: [ovs-dev] [PATCH 1/1] vlog: fix memory leak in vlog_set_log_file() function

2019-10-03 Thread Damijan Skvarc
Perfect! Thanks. On Wed, Oct 2, 2019 at 5:39 PM Ben Pfaff wrote: > On Wed, Oct 02, 2019 at 01:44:49PM +0200, Damijan Skvarc wrote: > > memory leak happens in case previously closed log file was reopened > again, > > for example: > > > > ovs-appctl vlog/close > > ovs-appctl vlog/reopen > >

Re: [ovs-dev] [PATCH 1/1] vlog: fix memory leak in vlog_set_log_file() function

2019-10-02 Thread Ben Pfaff
On Wed, Oct 02, 2019 at 01:44:49PM +0200, Damijan Skvarc wrote: > memory leak happens in case previously closed log file was reopened again, > for example: > > ovs-appctl vlog/close > ovs-appctl vlog/reopen Thanks. I applied this to master. I removed the 'if' here, since free(NULL) is a no-op:

[ovs-dev] [PATCH 1/1] vlog: fix memory leak in vlog_set_log_file() function

2019-10-02 Thread Damijan Skvarc
memory leak happens in case previously closed log file was reopened again, for example: ovs-appctl vlog/close ovs-appctl vlog/reopen memory leak is reported by valgrind in a form: ==4463== 76 bytes in 1 blocks are definitely lost in loss record 322 of 344 ==4463==at 0x4C2DB8F: malloc (in