Re: [ovs-dev] [PATCH 1/3] tunnel: Avoid flow_to_string() call when rate-limited.

2018-01-04 Thread Ben Pfaff
Thanks Yifeng (and Ansis, off-list). I applied this to master. On Thu, Dec 28, 2017 at 02:30:33PM -0800, Yifeng Sun wrote: > Looks good, thanks for the change. > > Reviewed-by: Yifeng Sun > > On Thu, Dec 28, 2017 at 12:34 PM, Ben Pfaff wrote: > > > flow_to_string() is relatively expensive.

Re: [ovs-dev] [PATCH 1/3] tunnel: Avoid flow_to_string() call when rate-limited.

2017-12-28 Thread Yifeng Sun
Looks good, thanks for the change. Reviewed-by: Yifeng Sun On Thu, Dec 28, 2017 at 12:34 PM, Ben Pfaff wrote: > flow_to_string() is relatively expensive. It is better to avoid it if the > string is not actually going to be used. > > Signed-off-by: Ben Pfaff > --- > ofproto/tunnel.c | 9

[ovs-dev] [PATCH 1/3] tunnel: Avoid flow_to_string() call when rate-limited.

2017-12-28 Thread Ben Pfaff
flow_to_string() is relatively expensive. It is better to avoid it if the string is not actually going to be used. Signed-off-by: Ben Pfaff --- ofproto/tunnel.c | 9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/ofproto/tunnel.c b/ofproto/tunnel.c index 1676f4d46fdf..9