Re: [ovs-dev] [PATCH 1/5] dpif-netdev: Rework rxq scheduling code.

2021-07-01 Thread Kevin Traynor
On 22/06/2021 20:02, Pai G, Sunil wrote: > Hey Kevin , > > Patch looks good to me: > > Builds fine , all test cases here > http://patchwork.ozlabs.org/project/openvswitch/patch/20210316154532.127858-1-ktray...@redhat.com/ > pass as well. > > Some minor nits inline : > > > >> diff --git

Re: [ovs-dev] [PATCH 1/5] dpif-netdev: Rework rxq scheduling code.

2021-07-01 Thread Kevin Traynor
On 23/06/2021 14:04, David Marchand wrote: > On Fri, Jun 4, 2021 at 11:19 PM Kevin Traynor wrote: >> >> This reworks the current rxq scheduling code to break it into more >> generic and reusable pieces. >> >> The behaviour does not change from a user perspective, except the logs >> are updated to

Re: [ovs-dev] [PATCH 1/5] dpif-netdev: Rework rxq scheduling code.

2021-06-23 Thread David Marchand
On Fri, Jun 4, 2021 at 11:19 PM Kevin Traynor wrote: > > This reworks the current rxq scheduling code to break it into more > generic and reusable pieces. > > The behaviour does not change from a user perspective, except the logs > are updated to be more consistent. > > From an implementation

Re: [ovs-dev] [PATCH 1/5] dpif-netdev: Rework rxq scheduling code.

2021-06-22 Thread Pai G, Sunil
Hey Kevin , Patch looks good to me: Builds fine , all test cases here http://patchwork.ozlabs.org/project/openvswitch/patch/20210316154532.127858-1-ktray...@redhat.com/ pass as well. Some minor nits inline : > diff --git a/lib/dpif-netdev.c b/lib/dpif-netdev.c index 650e67ab3..57d23e112

[ovs-dev] [PATCH 1/5] dpif-netdev: Rework rxq scheduling code.

2021-06-04 Thread Kevin Traynor
This reworks the current rxq scheduling code to break it into more generic and reusable pieces. The behaviour does not change from a user perspective, except the logs are updated to be more consistent. >From an implementation view, there are some changes with mind to adding functionality and