Re: [ovs-dev] [PATCH 1/5] ofproto: Fix double-unref of temporary rule when learning.

2018-01-26 Thread Ben Pfaff
On Fri, Jan 26, 2018 at 07:40:37AM -0800, William Tu wrote: > On Thu, Jan 25, 2018 at 3:39 PM, Ben Pfaff wrote: > > When ofproto_flow_mod_init() accepts a rule, it takes ownership of it and > > either unrefs it on error or transfers ownership to the struct it > > initializes on

Re: [ovs-dev] [PATCH 1/5] ofproto: Fix double-unref of temporary rule when learning.

2018-01-26 Thread William Tu
On Thu, Jan 25, 2018 at 3:39 PM, Ben Pfaff wrote: > When ofproto_flow_mod_init() accepts a rule, it takes ownership of it and > either unrefs it on error or transfers ownership to the struct it > initializes on success, but ofproto_flow_mod_init_for_learn() was unref-ing > it a

[ovs-dev] [PATCH 1/5] ofproto: Fix double-unref of temporary rule when learning.

2018-01-25 Thread Ben Pfaff
When ofproto_flow_mod_init() accepts a rule, it takes ownership of it and either unrefs it on error or transfers ownership to the struct it initializes on success, but ofproto_flow_mod_init_for_learn() was unref-ing it a second time if it reported an error. Signed-off-by: Ben Pfaff