Re: [ovs-dev] [PATCH 1/8] ip6_gre: Fix a bug that clears address bits

Hi Greg, Thanks for clarifying this bug, you did a much better job than I did. Sorry I didn't describe it clearly. I will created another patch, as you suggested. William, below is the crash dump you requested. [ 645.832991] general protection fault: [#1] SMP PTI [ 645.833033] Modules l

Re: [ovs-dev] [PATCH 1/8] ip6_gre: Fix a bug that clears address bits

On 8/8/2018 11:32 AM, Yifeng Sun wrote: In compatable gre module, skb->cb is used as ovs_gso_cb. This bug clears the 16-23 bit in the address of ovs_gso_cb.tun_dst. Signed-off-by: Yifeng Sun --- datapath/linux/compat/ip6_gre.c | 1 - 1 file changed, 1 deletion(-) diff --git a/datapath/linux

Re: [ovs-dev] [PATCH 1/8] ip6_gre: Fix a bug that clears address bits

On 8/9/2018 3:33 PM, William Tu wrote: On Thu, Aug 9, 2018 at 2:37 PM, Gregory Rose > wrote: On 8/9/2018 11:36 AM, Yifeng Sun wrote: Yes, I agree. It should be the way to go. Thanks, Yifeng If I'm reading the code correctly the OVS packet

Re: [ovs-dev] [PATCH 1/8] ip6_gre: Fix a bug that clears address bits

On Thu, Aug 9, 2018 at 2:37 PM, Gregory Rose wrote: > On 8/9/2018 11:36 AM, Yifeng Sun wrote: > > Yes, I agree. It should be the way to go. > > Thanks, > Yifeng > > > If I'm reading the code correctly the OVS packet cmd will set the skb->cb > using the OVS_CB macro and then > pass that packet dow

Re: [ovs-dev] [PATCH 1/8] ip6_gre: Fix a bug that clears address bits

On 8/9/2018 11:36 AM, Yifeng Sun wrote: Yes, I agree. It should be the way to go. Thanks, Yifeng If I'm reading the code correctly the OVS packet cmd will set the skb->cb using the OVS_CB macro and then pass that packet down to the ip6erspan_tunnel_xmit function.  The ip6erspan_tunnel_xmit

Re: [ovs-dev] [PATCH 1/8] ip6_gre: Fix a bug that clears address bits

Yes, I agree. It should be the way to go. Thanks, Yifeng On Thu, Aug 9, 2018 at 11:17 AM, Gregory Rose wrote: > On 8/9/2018 11:03 AM, Yifeng Sun wrote: > > There is a difference regarding how skb_tunnel_info is stored in skb > between ovs and upstream kernel. In ovs's compatible gre module, > s

Re: [ovs-dev] [PATCH 1/8] ip6_gre: Fix a bug that clears address bits

On 8/9/2018 11:03 AM, Yifeng Sun wrote: There is a difference regarding how skb_tunnel_info is stored in skb between ovs and upstream kernel. In ovs's compatible gre module, skb_tunnel_info is stored in skb->cb while in upstream kernel, it is referenced by skb->_skb_refdst. The upstream netdev c

Re: [ovs-dev] [PATCH 1/8] ip6_gre: Fix a bug that clears address bits

There is a difference regarding how skb_tunnel_info is stored in skb between ovs and upstream kernel. In ovs's compatible gre module, skb_tunnel_info is stored in skb->cb while in upstream kernel, it is referenced by skb->_skb_refdst. The upstream netdev code should be okay. To fix this issue, my

Re: [ovs-dev] [PATCH 1/8] ip6_gre: Fix a bug that clears address bits

On 8/8/2018 6:50 PM, William Tu wrote: thanks for the fix. On Wed, Aug 8, 2018 at 11:32 AM, Yifeng Sun wrote: In compatable gre module, skb->cb is used as ovs_gso_cb. This bug clears the 16-23 bit in the address of ovs_gso_cb.tun_dst. can you explain more about ovs_gso_cb? Signed-off-by:

Re: [ovs-dev] [PATCH 1/8] ip6_gre: Fix a bug that clears address bits

thanks for the fix. On Wed, Aug 8, 2018 at 11:32 AM, Yifeng Sun wrote: > In compatable gre module, skb->cb is used as ovs_gso_cb. > This bug clears the 16-23 bit in the address of ovs_gso_cb.tun_dst. > can you explain more about ovs_gso_cb? > > Signed-off-by: Yifeng Sun > --- > datapath/linu

[ovs-dev] [PATCH 1/8] ip6_gre: Fix a bug that clears address bits

In compatable gre module, skb->cb is used as ovs_gso_cb. This bug clears the 16-23 bit in the address of ovs_gso_cb.tun_dst. Signed-off-by: Yifeng Sun --- datapath/linux/compat/ip6_gre.c | 1 - 1 file changed, 1 deletion(-) diff --git a/datapath/linux/compat/ip6_gre.c b/datapath/linux/compat/ip