> Subiect: Re: [ovs-dev] [PATCH 2/2] Datapath: Fix ovs_vport_init unreachable
> code and goto labels
>
> I think the correct fix may be as follows, do you mind rechecking it?
> Thanks.
>
> diff --git a/datapath/vport.c b/datapath/vport.c index
> 02f6b56d3243..fcf0fea0a245
I think you're right.
On Mon, Jul 09, 2018 at 11:04:03AM -0700, Yifeng Sun wrote:
> I think the correct fix may be as follows, do you mind rechecking it?
> Thanks.
>
> diff --git a/datapath/vport.c b/datapath/vport.c
> index 02f6b56d3243..fcf0fea0a245 100644
> --- a/datapath/vport.c
> +++
I think the correct fix may be as follows, do you mind rechecking it?
Thanks.
diff --git a/datapath/vport.c b/datapath/vport.c
index 02f6b56d3243..fcf0fea0a245 100644
--- a/datapath/vport.c
+++ b/datapath/vport.c
@@ -93,7 +93,6 @@ int ovs_vport_init(void)
goto err_stt;
The line "ovs_stt_cleanup_module();" was unreachable. Looking
at the rest of the goto labels they also seem wrong, so fix them also.
Found using static analysis tools.
Signed-off-by: Alin Gabriel Serdean
---
datapath/vport.c | 17 +
1 file changed, 9 insertions(+), 8
