Re: [ovs-dev] [PATCH 2/2] dpif-netdev: Indicate support for various ct features.

2017-07-19 Thread Justin Pettit
> On Jul 19, 2017, at 3:18 PM, Darrell Ball wrote: > > I could not see any; it is good the impact from this hybrid support thing > was limited > to debug o/p then. > I don't see any new issues from this patch addition, and it is the only > reasonable > option for backporting. > > In your ori

Re: [ovs-dev] [PATCH 2/2] dpif-netdev: Indicate support for various ct features.

2017-07-19 Thread Darrell Ball
-Original Message- From: on behalf of Joe Stringer Date: Wednesday, July 19, 2017 at 2:54 PM To: Darrell Ball Cc: "d...@openvswitch.org" Subject: Re: [ovs-dev] [PATCH 2/2] dpif-netdev: Indicate support for various ct features. On 19 July 2017 at 14:11, Darrell B

Re: [ovs-dev] [PATCH 2/2] dpif-netdev: Indicate support for various ct features.

2017-07-19 Thread Joe Stringer
On 19 July 2017 at 14:11, Darrell Ball wrote: > On Wed, Jul 19, 2017 at 1:18 PM, Darrell Ball wrote: >> On Wed, Jul 19, 2017 at 12:17 PM, Justin Pettit wrote: >>> > On Jul 19, 2017, at 10:45 AM, Darrell Ball wrote: >>> > On 7/19/17, 8:01 AM, "Justin Pettit" wrote: >>> >> On Jul 19, 2017, at 2:

Re: [ovs-dev] [PATCH 2/2] dpif-netdev: Indicate support for various ct features.

2017-07-19 Thread Darrell Ball
[Darrell] Backporting may not apply here as none of Jarno's original tuple code made it to 2.7. On Wed, Jul 19, 2017 at 1:18 PM, Darrell Ball wrote: > > > On Wed, Jul 19, 2017 at 12:17 PM, Justin Pettit wrote: > >> >> > On Jul 19, 2017, at 10:45 AM, Darrell Ball wrote: >> > >>

Re: [ovs-dev] [PATCH 2/2] dpif-netdev: Indicate support for various ct features.

2017-07-19 Thread Darrell Ball
On Wed, Jul 19, 2017 at 12:17 PM, Justin Pettit wrote: > > > On Jul 19, 2017, at 10:45 AM, Darrell Ball wrote: > > > > > > > > On 7/19/17, 8:01 AM, "Justin Pettit" wrote: > > > > > >> On Jul 19, 2017, at 2:45 AM, Darrell Ball wrote: > >> > >> This change does not seem to be all that useful. >

Re: [ovs-dev] [PATCH 2/2] dpif-netdev: Indicate support for various ct features.

2017-07-19 Thread Justin Pettit
> On Jul 19, 2017, at 10:45 AM, Darrell Ball wrote: > > > > On 7/19/17, 8:01 AM, "Justin Pettit" wrote: > > >> On Jul 19, 2017, at 2:45 AM, Darrell Ball wrote: >> >> This change does not seem to be all that useful. >> >> When rules are constructed, mask and action support do check previo

Re: [ovs-dev] [PATCH 2/2] dpif-netdev: Indicate support for various ct features.

2017-07-19 Thread Darrell Ball
On 7/19/17, 8:01 AM, "Justin Pettit" wrote: > On Jul 19, 2017, at 2:45 AM, Darrell Ball wrote: > > This change does not seem to be all that useful. > > When rules are constructed, mask and action support do check previously probed support > which will be ‘TRUE’.

Re: [ovs-dev] [PATCH 2/2] dpif-netdev: Indicate support for various ct features.

2017-07-19 Thread Justin Pettit
> On Jul 19, 2017, at 2:45 AM, Darrell Ball wrote: > > This change does not seem to be all that useful. > > When rules are constructed, mask and action support do check previously > probed support > which will be ‘TRUE’. > > Another way to see that the below settings are not useful is to set

Re: [ovs-dev] [PATCH 2/2] dpif-netdev: Indicate support for various ct features.

2017-07-19 Thread Darrell Ball
This change does not seem to be all that useful. When rules are constructed, mask and action support do check previously probed support which will be ‘TRUE’. Another way to see that the below settings are not useful is to set everything to ‘false’ (see below) and run all the system tests in use

[ovs-dev] [PATCH 2/2] dpif-netdev: Indicate support for various ct features.

2017-07-18 Thread Justin Pettit
The userspace datapath hardcodes support for the features it supports, but it was missing "ct_state_nat", "ct_orig_tuple", and "ct_orig_tuple6". Signed-off-by: Justin Pettit --- lib/dpif-netdev.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/lib/dpif-netdev.c b/lib/dpif-netdev.c index 1