Re: [ovs-dev] [PATCH 2/2] netdev-dpdk: fix snprintf call

2018-06-14 Thread Aaron Conole
Ben Pfaff writes: > On Thu, Jun 14, 2018 at 05:11:39PM -0400, Aaron Conole wrote: >> Ben Pfaff writes: >> >> > On Wed, Jun 13, 2018 at 03:43:04PM -0400, Aaron Conole wrote: >> >> lib/netdev-dpdk.c: In function : >> >> lib/netdev-dpdk.c:2865:49: warning: output may be truncated before the >> >

Re: [ovs-dev] [PATCH 2/2] netdev-dpdk: fix snprintf call

2018-06-14 Thread Ben Pfaff
On Thu, Jun 14, 2018 at 05:11:39PM -0400, Aaron Conole wrote: > Ben Pfaff writes: > > > On Wed, Jun 13, 2018 at 03:43:04PM -0400, Aaron Conole wrote: > >> lib/netdev-dpdk.c: In function : > >> lib/netdev-dpdk.c:2865:49: warning: output may be truncated before the > >> last format character [-Wf

Re: [ovs-dev] [PATCH 2/2] netdev-dpdk: fix snprintf call

2018-06-14 Thread Aaron Conole
Ben Pfaff writes: > On Wed, Jun 13, 2018 at 03:43:04PM -0400, Aaron Conole wrote: >> lib/netdev-dpdk.c: In function : >> lib/netdev-dpdk.c:2865:49: warning: output may be truncated before the last >> format character [-Wformat-truncation=] >> snprintf(vhost_vring, 16, "vring_%d_size", i

Re: [ovs-dev] [PATCH 2/2] netdev-dpdk: fix snprintf call

2018-06-14 Thread Aaron Conole
Ben Pfaff writes: > On Wed, Jun 13, 2018 at 03:43:04PM -0400, Aaron Conole wrote: >> lib/netdev-dpdk.c: In function : >> lib/netdev-dpdk.c:2865:49: warning: output may be truncated before the last >> format character [-Wformat-truncation=] >> snprintf(vhost_vring, 16, "vring_%d_size", i

Re: [ovs-dev] [PATCH 2/2] netdev-dpdk: fix snprintf call

2018-06-14 Thread Ben Pfaff
On Wed, Jun 13, 2018 at 03:43:04PM -0400, Aaron Conole wrote: > lib/netdev-dpdk.c: In function : > lib/netdev-dpdk.c:2865:49: warning: output may be truncated before the last > format character [-Wformat-truncation=] > snprintf(vhost_vring, 16, "vring_%d_size", i); >

Re: [ovs-dev] [PATCH 2/2] netdev-dpdk: fix snprintf call

2018-06-14 Thread Yifeng Sun
Looks good to me, thanks. Reviewed-by: Yifeng Sun On Wed, Jun 13, 2018 at 12:43 PM, Aaron Conole wrote: > lib/netdev-dpdk.c: In function : > lib/netdev-dpdk.c:2865:49: warning: output may be truncated before the > last format character [-Wformat-truncation=] > snprintf(vhost_vring, 16

[ovs-dev] [PATCH 2/2] netdev-dpdk: fix snprintf call

2018-06-13 Thread Aaron Conole
lib/netdev-dpdk.c: In function : lib/netdev-dpdk.c:2865:49: warning: output may be truncated before the last format character [-Wformat-truncation=] snprintf(vhost_vring, 16, "vring_%d_size", i); ^ lib/netdev-dpdk.c:2865:9: note: output bet