Re: [ovs-dev] [PATCH 2/3] OVN: add icmp4{} action support

2018-02-15 Thread Ben Pfaff
On Thu, Feb 15, 2018 at 02:24:24PM +0100, Lorenzo Bianconi wrote: > > On Tue, Feb 13, 2018 at 03:43:51PM +0100, Lorenzo Bianconi wrote: > > I'm appending a few changes I suggest folding in: usually we write hex > > numbers preceded by 0x (which the # flag does), and because the two > > lines that

Re: [ovs-dev] [PATCH 2/3] OVN: add icmp4{} action support

2018-02-15 Thread Lorenzo Bianconi
> On Tue, Feb 13, 2018 at 03:43:51PM +0100, Lorenzo Bianconi wrote: >> icmp4 action is used to replace the IPv4 packet been processed with >> an ICMPv4 packet initialized based on incoming IPv4 one. >> Ethernet and IPv4 fields not listed are not changed: >> - ip.proto = 1 (ICMPv4) >> - ip.frag = 0

Re: [ovs-dev] [PATCH 2/3] OVN: add icmp4{} action support

2018-02-14 Thread Ben Pfaff
On Tue, Feb 13, 2018 at 03:43:51PM +0100, Lorenzo Bianconi wrote: > icmp4 action is used to replace the IPv4 packet been processed with > an ICMPv4 packet initialized based on incoming IPv4 one. > Ethernet and IPv4 fields not listed are not changed: > - ip.proto = 1 (ICMPv4) > - ip.frag = 0 (not a

[ovs-dev] [PATCH 2/3] OVN: add icmp4{} action support

2018-02-13 Thread Lorenzo Bianconi
icmp4 action is used to replace the IPv4 packet been processed with an ICMPv4 packet initialized based on incoming IPv4 one. Ethernet and IPv4 fields not listed are not changed: - ip.proto = 1 (ICMPv4) - ip.frag = 0 (not a fragment) - icmp4.type = 3 (destination unreachable) - icmp4.code = 1 (host