Re: [ovs-dev] [PATCH 2/3] tc: Split IPs and transport layer ports unions in flower struct

2017-07-30 Thread Paul Blakey
On 30/07/2017 10:22, Roi Dayan wrote: On 28/07/2017 15:49, Simon Horman wrote: On Thu, Jul 27, 2017 at 01:19:59PM +0300, Roi Dayan wrote: From: Paul Blakey Split dst/src_port and ipv4/ipv6 union so we can distingush them easily for later features. The implications

Re: [ovs-dev] [PATCH 2/3] tc: Split IPs and transport layer ports unions in flower struct

2017-07-30 Thread Roi Dayan
On 28/07/2017 15:49, Simon Horman wrote: On Thu, Jul 27, 2017 at 01:19:59PM +0300, Roi Dayan wrote: From: Paul Blakey Split dst/src_port and ipv4/ipv6 union so we can distingush them easily for later features. The implications of this change on the size of struct

Re: [ovs-dev] [PATCH 2/3] tc: Split IPs and transport layer ports unions in flower struct

2017-07-28 Thread Simon Horman
On Thu, Jul 27, 2017 at 01:19:59PM +0300, Roi Dayan wrote: > From: Paul Blakey > > Split dst/src_port and ipv4/ipv6 union so we can > distingush them easily for later features. The implications of this change on the size of struct tc_flower_key seem somewhat undesirable to

[ovs-dev] [PATCH 2/3] tc: Split IPs and transport layer ports unions in flower struct

2017-07-27 Thread Roi Dayan
From: Paul Blakey Split dst/src_port and ipv4/ipv6 union so we can distingush them easily for later features. Signed-off-by: Paul Blakey Reviewed-by: Roi Dayan --- lib/netdev-tc-offloads.c | 29 + lib/tc.c