Re: [ovs-dev] [PATCH 2/5] netdev-dpdk: Fix sparse complaints.

2018-07-24 Thread Ben Pfaff
It's because htons() and ntohs() actually do the same thing (swap bytes). On Mon, Jul 16, 2018 at 11:06:56AM -0700, Yifeng Sun wrote: > Thanks for the fix. I am wondering why there was no running issue when > dl_type is compared with wrong byte order. > > Reviewed-by: Yifeng Sun > > On Thu,

Re: [ovs-dev] [PATCH 2/5] netdev-dpdk: Fix sparse complaints.

2018-07-17 Thread Ian Stokes
On 7/16/2018 7:06 PM, Yifeng Sun wrote: Thanks for the fix. I am wondering why there was no running issue when dl_type is compared with wrong byte order. Reviewed-by: Yifeng Sun On Thu, Jul 12, 2018 at 2:55 PM, Ben Pfaff wrote: Neither of these is a real problem. Seems ok to me, adding

Re: [ovs-dev] [PATCH 2/5] netdev-dpdk: Fix sparse complaints.

2018-07-16 Thread Yifeng Sun
Thanks for the fix. I am wondering why there was no running issue when dl_type is compared with wrong byte order. Reviewed-by: Yifeng Sun On Thu, Jul 12, 2018 at 2:55 PM, Ben Pfaff wrote: > Neither of these is a real problem. > > Signed-off-by: Ben Pfaff > --- > lib/netdev-dpdk.c | 6 +++---

[ovs-dev] [PATCH 2/5] netdev-dpdk: Fix sparse complaints.

2018-07-12 Thread Ben Pfaff
Neither of these is a real problem. Signed-off-by: Ben Pfaff --- lib/netdev-dpdk.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/lib/netdev-dpdk.c b/lib/netdev-dpdk.c index b4ed4ad5919c..d485a53dacf1 100644 --- a/lib/netdev-dpdk.c +++ b/lib/netdev-dpdk.c @@ -4384,7