Re: [ovs-dev] [PATCH 23/27] ovn-trace: Add some basic tracing for ct_snat and ct_dnat actions.

2017-05-03 Thread Ben Pfaff
On Tue, May 02, 2017 at 11:33:27AM -0700, Mickey Spiegel wrote: > One minor nit and one real comment below. > > On Tue, May 2, 2017 at 11:07 AM, Ben Pfaff wrote: > > > On Mon, May 01, 2017 at 05:50:57PM -0700, Mickey Spiegel wrote: > > > On Mon, May 1, 2017 at 5:12 PM, Ben Pfaff

Re: [ovs-dev] [PATCH 23/27] ovn-trace: Add some basic tracing for ct_snat and ct_dnat actions.

2017-05-02 Thread Mickey Spiegel
One minor nit and one real comment below. On Tue, May 2, 2017 at 11:07 AM, Ben Pfaff wrote: > On Mon, May 01, 2017 at 05:50:57PM -0700, Mickey Spiegel wrote: > > On Mon, May 1, 2017 at 5:12 PM, Ben Pfaff wrote: > > > > > On Mon, May 01, 2017 at 03:39:32PM -0700,

Re: [ovs-dev] [PATCH 23/27] ovn-trace: Add some basic tracing for ct_snat and ct_dnat actions.

2017-05-02 Thread Ben Pfaff
On Mon, May 01, 2017 at 05:50:57PM -0700, Mickey Spiegel wrote: > On Mon, May 1, 2017 at 5:12 PM, Ben Pfaff wrote: > > > On Mon, May 01, 2017 at 03:39:32PM -0700, Mickey Spiegel wrote: > > > On Sun, Apr 30, 2017 at 4:22 PM, Ben Pfaff wrote: > > > > > > > Without this

Re: [ovs-dev] [PATCH 23/27] ovn-trace: Add some basic tracing for ct_snat and ct_dnat actions.

2017-05-01 Thread Mickey Spiegel
On Mon, May 1, 2017 at 5:12 PM, Ben Pfaff wrote: > On Mon, May 01, 2017 at 03:39:32PM -0700, Mickey Spiegel wrote: > > On Sun, Apr 30, 2017 at 4:22 PM, Ben Pfaff wrote: > > > > > Without this support, ovn-trace is not very useful with OpenStack, > which > > > uses

Re: [ovs-dev] [PATCH 23/27] ovn-trace: Add some basic tracing for ct_snat and ct_dnat actions.

2017-05-01 Thread Ben Pfaff
On Mon, May 01, 2017 at 03:39:32PM -0700, Mickey Spiegel wrote: > On Sun, Apr 30, 2017 at 4:22 PM, Ben Pfaff wrote: > > > Without this support, ovn-trace is not very useful with OpenStack, which > > uses connection tracking extensively. > > > > I scanned the patch set briefly, not

[ovs-dev] [PATCH 23/27] ovn-trace: Add some basic tracing for ct_snat and ct_dnat actions.

2017-04-30 Thread Ben Pfaff
Without this support, ovn-trace is not very useful with OpenStack, which uses connection tracking extensively. Signed-off-by: Ben Pfaff --- ovn/utilities/ovn-trace.8.xml | 50 +++ ovn/utilities/ovn-trace.c | 43