Re: [ovs-dev] [PATCH 3/7] netdev-dpdk: Add support for keepalive functionality.

2017-04-24 Thread Bodireddy, Bhanuprakash
>>> The relay function is called by 'ovs_keepalive' thread. I didn't >>> completely understand your concerns here. I would be happy to verify >>> if you have any scenarios in mind that you think pose problems. >> >>My concern stems from this: >> "is relayed to monitoring framework by unlocking

Re: [ovs-dev] [PATCH 3/7] netdev-dpdk: Add support for keepalive functionality.

2017-04-03 Thread Bodireddy, Bhanuprakash
>>> >>>This whole mechanism seems very error prone. Is it possible to hang a >>>thread with the subsequent sem_post? >> >> The relay function is called by 'ovs_keepalive' thread. I didn't >> completely understand your concerns here. I would be happy to verify >> if you have any scenarios in mind

Re: [ovs-dev] [PATCH 3/7] netdev-dpdk: Add support for keepalive functionality.

2017-04-03 Thread Aaron Conole
"Bodireddy, Bhanuprakash" writes: >>> >>> +/* >>> + * OVS Shared Memory structure >>> + * >>> + * The information in the shared memory block will be read by collectd. >>> + * */ >>> +struct dpdk_keepalive_shm { >>> +/* IPC semaphore. Posted when a core dies

Re: [ovs-dev] [PATCH 3/7] netdev-dpdk: Add support for keepalive functionality.

2017-04-03 Thread Bodireddy, Bhanuprakash
>> >> +/* >> + * OVS Shared Memory structure >> + * >> + * The information in the shared memory block will be read by collectd. >> + * */ >> +struct dpdk_keepalive_shm { >> +/* IPC semaphore. Posted when a core dies */ >> +sem_t core_died; >> + >> +/* >> + * Relayed status of each

Re: [ovs-dev] [PATCH 3/7] netdev-dpdk: Add support for keepalive functionality.

2017-04-02 Thread Aaron Conole
Bhanuprakash Bodireddy writes: > This commit initializes the keepalive subsystem and spawns keepalive > thread that wakes up at regular intervals to update the timestamp and > status of pmd cores in shared memory. > > This patch implements POSIX shared memory