Re: [ovs-dev] [PATCH net-next] net: fix return type of ndo_start_xmit function

2018-09-17 Thread YueHaibing
On 2018/9/17 23:09, David Miller wrote: > > Please don't do this. > > The hard part of fixing this is not what you are doing, changing the > return type. > > The hard part is fixing each and every function to actually return > values which are members of the netdev_tx_t enumeration. > >

Re: [ovs-dev] [PATCH net-next] net: fix return type of ndo_start_xmit function

2018-09-17 Thread David Miller
Please don't do this. The hard part of fixing this is not what you are doing, changing the return type. The hard part is fixing each and every function to actually return values which are members of the netdev_tx_t enumeration. Please fix each and every function properly. Thank you.

[ovs-dev] [PATCH net-next] net: fix return type of ndo_start_xmit function

2018-09-15 Thread YueHaibing
The method ndo_start_xmit() is defined as returning an 'netdev_tx_t', which is a typedef for an enum type, but the implementation in many drivers returns an 'int'. Found by coccinelle. Signed-off-by: YueHaibing --- drivers/net/caif/caif_hsi.c | 2 +-