Re: [ovs-dev] [PATCH net-next 3/3] net: sched: add helper support in act_ct

2022-10-06 Thread Xin Long
On Thu, Oct 6, 2022 at 10:11 AM Pablo Neira Ayuso wrote: > > On Tue, Oct 04, 2022 at 09:19:56PM -0400, Xin Long wrote: > [...] > > @@ -1119,6 +1135,22 @@ static int tcf_ct_act(struct sk_buff *skb, const > > struct tc_action *a, > > if (err != NF_ACCEPT) > > goto drop; > > > >

Re: [ovs-dev] [PATCH net-next 3/3] net: sched: add helper support in act_ct

2022-10-06 Thread Pablo Neira Ayuso
On Tue, Oct 04, 2022 at 09:19:56PM -0400, Xin Long wrote: [...] > @@ -1119,6 +1135,22 @@ static int tcf_ct_act(struct sk_buff *skb, const > struct tc_action *a, > if (err != NF_ACCEPT) > goto drop; > > + if (commit && p->helper && !nfct_help(ct)) { > + err =

Re: [ovs-dev] [PATCH net-next 3/3] net: sched: add helper support in act_ct

2022-10-06 Thread Xin Long
On Thu, Oct 6, 2022 at 5:57 AM Paolo Abeni wrote: > > On Tue, 2022-10-04 at 21:19 -0400, Xin Long wrote: > > This patch is to add helper support in act_ct for OVS actions=ct(alg=xxx) > > offloading, which is corresponding to Commit cae3a2627520 ("openvswitch: > > Allow attaching helpers to ct

Re: [ovs-dev] [PATCH net-next 3/3] net: sched: add helper support in act_ct

2022-10-06 Thread Paolo Abeni
On Tue, 2022-10-04 at 21:19 -0400, Xin Long wrote: > This patch is to add helper support in act_ct for OVS actions=ct(alg=xxx) > offloading, which is corresponding to Commit cae3a2627520 ("openvswitch: > Allow attaching helpers to ct action") in OVS kernel part. > > The difference is when adding

[ovs-dev] [PATCH net-next 3/3] net: sched: add helper support in act_ct

2022-10-05 Thread Xin Long
This patch is to add helper support in act_ct for OVS actions=ct(alg=xxx) offloading, which is corresponding to Commit cae3a2627520 ("openvswitch: Allow attaching helpers to ct action") in OVS kernel part. The difference is when adding TC actions family and proto cannot be got from the