Re: [ovs-dev] [PATCH net-next v1 1/3] gtp: refactor to support flow-based gtp encap and decap

On Mon, Jul 31, 2017 at 09:21:36AM +0200, Andreas Schultz wrote: > Hi Jiannan, > > - On Jul 13, 2017, at 2:44 AM, Jiannan Ouyang ouya...@fb.com wrote: > > [...] > > > -static int gtp_rx(struct pdp_ctx *pctx, struct sk_buff *skb, > > - unsigned int hdrlen, unsigned int

Re: [ovs-dev] [PATCH net-next v1 1/3] gtp: refactor to support flow-based gtp encap and decap

Hi Jiannan, - On Jul 13, 2017, at 2:44 AM, Jiannan Ouyang ouya...@fb.com wrote: [...] > -static int gtp_rx(struct pdp_ctx *pctx, struct sk_buff *skb, > - unsigned int hdrlen, unsigned int role) > +static int gtp_rx(struct gtp_dev *gtp, struct sk_buff *skb, > +

Re: [ovs-dev] [PATCH net-next v1 1/3] gtp: refactor to support flow-based gtp encap and decap

Hi Jiannan, > > > gtp = netdev_priv(dev); > > > + gtp->net = src_net; > >· > > Isn't this a generic change that's independent of your work on OVS GTP? > > It is meant to be OVS independent. What makes it not? Should I leave > this field un-initialized? In general, in all FOSS projects I

Re: [ovs-dev] [PATCH net-next v1 1/3] gtp: refactor to support flow-based gtp encap and decap

Hi Harald, > On 7/13/17, 12:26 AM, "Harald Welte" wrote: >· > > static inline void gtp_set_pktinfo_ipv4(struct gtp_pktinfo *pktinfo, > > struct sock *sk, struct iphdr *iph, > > - struct pdp_ctx *pctx, struct rtable *rt, > > - struct flowi4 *fl4, >

[ovs-dev] [PATCH net-next v1 1/3] gtp: refactor to support flow-based gtp encap and decap

If flow-based encap/decap is enabled, a separate code path is created for both packet RX and TX. PDP contexts are not used in flow-based mode since all metadata is maintained in metadata_dst: - for RX, pdp lookup and ms check are bypassed, while metadata_dst is constructed and attached to the