Re: [ovs-dev] [PATCH net-next v6 05/10] net: openvswitch: optimize flow-mask looking up

2019-11-04 Thread William Tu
On Mon, Nov 4, 2019 at 2:10 PM Pravin Shelar wrote: > > On Mon, Nov 4, 2019 at 6:00 AM William Tu wrote: > > > > On Sat, Nov 2, 2019 at 11:50 PM Pravin Shelar wrote: > > > > > > On Fri, Nov 1, 2019 at 7:24 AM wrote: > > > > > > > > From: Tonghao Zhang > > > > > > > > The full looking up on

Re: [ovs-dev] [PATCH net-next v6 05/10] net: openvswitch: optimize flow-mask looking up

2019-11-04 Thread Pravin Shelar
On Mon, Nov 4, 2019 at 6:00 AM William Tu wrote: > > On Sat, Nov 2, 2019 at 11:50 PM Pravin Shelar wrote: > > > > On Fri, Nov 1, 2019 at 7:24 AM wrote: > > > > > > From: Tonghao Zhang > > > > > > The full looking up on flow table traverses all mask array. > > > If mask-array is too large, the

Re: [ovs-dev] [PATCH net-next v6 05/10] net: openvswitch: optimize flow-mask looking up

2019-11-04 Thread David Miller
From: William Tu Date: Mon, 4 Nov 2019 05:59:27 -0800 > Nack to this patch. These changes are already in net-next. If you already pointed out these problems in previous discussions, I'm sorry about that. ___ dev mailing list d...@openvswitch.org

Re: [ovs-dev] [PATCH net-next v6 05/10] net: openvswitch: optimize flow-mask looking up

2019-11-04 Thread William Tu
On Sat, Nov 2, 2019 at 11:50 PM Pravin Shelar wrote: > > On Fri, Nov 1, 2019 at 7:24 AM wrote: > > > > From: Tonghao Zhang > > > > The full looking up on flow table traverses all mask array. > > If mask-array is too large, the number of invalid flow-mask > > increase, performance will be drop.

Re: [ovs-dev] [PATCH net-next v6 05/10] net: openvswitch: optimize flow-mask looking up

2019-11-03 Thread Pravin Shelar
On Fri, Nov 1, 2019 at 7:24 AM wrote: > > From: Tonghao Zhang > > The full looking up on flow table traverses all mask array. > If mask-array is too large, the number of invalid flow-mask > increase, performance will be drop. > > One bad case, for example: M means flow-mask is valid and NULL >

[ovs-dev] [PATCH net-next v6 05/10] net: openvswitch: optimize flow-mask looking up

2019-11-01 Thread xiangxia . m . yue
From: Tonghao Zhang The full looking up on flow table traverses all mask array. If mask-array is too large, the number of invalid flow-mask increase, performance will be drop. One bad case, for example: M means flow-mask is valid and NULL of flow-mask means deleted.