Re: [ovs-dev] [PATCH net 1/1] net: openvswitch: Fix ct_state nat flags for conns arriving from tc

2022-01-06 Thread Jamal Hadi Salim
On 2022-01-05 11:18, Paul Blakey wrote: On Wed, 5 Jan 2022, Daniel Borkmann wrote: [..] Full ack on the bloat for corner cases like ovs offload, especially given distros just enable most stuff anyway and therefore no light fast path as with !CONFIG_NET_TC_SKB_EXT. :( Could this somehow

Re: [ovs-dev] [PATCH net 1/1] net: openvswitch: Fix ct_state nat flags for conns arriving from tc

2022-01-05 Thread Daniel Borkmann
On 1/5/22 3:57 PM, Jamal Hadi Salim wrote: On 2022-01-04 03:28, Paul Blakey wrote: [..] --- a/include/linux/skbuff.h +++ b/include/linux/skbuff.h @@ -287,7 +287,9 @@ struct tc_skb_ext {   __u32 chain;   __u16 mru;   __u16 zone; -    bool post_ct; +    bool post_ct:1; +    bool

Re: [ovs-dev] [PATCH net 1/1] net: openvswitch: Fix ct_state nat flags for conns arriving from tc

2022-01-05 Thread Jamal Hadi Salim
On 2022-01-04 03:28, Paul Blakey wrote: [..] --- a/include/linux/skbuff.h +++ b/include/linux/skbuff.h @@ -287,7 +287,9 @@ struct tc_skb_ext { __u32 chain; __u16 mru; __u16 zone; - bool post_ct; + bool post_ct:1; + bool post_ct_snat:1; + bool

Re: [ovs-dev] [PATCH net 1/1] net: openvswitch: Fix ct_state nat flags for conns arriving from tc

2022-01-05 Thread Paul Blakey via dev
On Wed, 5 Jan 2022, Daniel Borkmann wrote: > On 1/5/22 3:57 PM, Jamal Hadi Salim wrote: > > On 2022-01-04 03:28, Paul Blakey wrote: > > [..] > >> --- a/include/linux/skbuff.h > >> +++ b/include/linux/skbuff.h > >> @@ -287,7 +287,9 @@ struct tc_skb_ext { > >>   __u32 chain; > >>   __u16

Re: [ovs-dev] [PATCH net 1/1] net: openvswitch: Fix ct_state nat flags for conns arriving from tc

2022-01-05 Thread Paul Blakey via dev
On Tue, 4 Jan 2022, Jakub Kicinski wrote: > On Tue, 4 Jan 2022 10:28:21 +0200 Paul Blakey wrote: > > Netfilter conntrack maintains NAT flags per connection indicating > > whether NAT was configured for the connection. Openvswitch maintains > > NAT flags on the per packet flow key ct_state

Re: [ovs-dev] [PATCH net 1/1] net: openvswitch: Fix ct_state nat flags for conns arriving from tc

2022-01-04 Thread Jakub Kicinski
On Tue, 4 Jan 2022 10:28:21 +0200 Paul Blakey wrote: > Netfilter conntrack maintains NAT flags per connection indicating > whether NAT was configured for the connection. Openvswitch maintains > NAT flags on the per packet flow key ct_state field, indicating > whether NAT was actually executed on

[ovs-dev] [PATCH net 1/1] net: openvswitch: Fix ct_state nat flags for conns arriving from tc

2022-01-04 Thread Paul Blakey via dev
Netfilter conntrack maintains NAT flags per connection indicating whether NAT was configured for the connection. Openvswitch maintains NAT flags on the per packet flow key ct_state field, indicating whether NAT was actually executed on the packet. When a packet misses from tc to ovs the conntrack