Re: [ovs-dev] [PATCH net 1/2] net: openvswitch: limit the number of recursions from action sets

2024-02-06 Thread Aaron Conole
Eric Dumazet writes: > On Tue, Feb 6, 2024 at 3:55 PM Aaron Conole wrote: >> >> >> Oops - I didn't consider it. >> >> Given that, maybe the best approach would not to rely on per-cpu >> counter. I'll respin in the next series with a depth counter that I pass >> to the function instead and

Re: [ovs-dev] [PATCH net 1/2] net: openvswitch: limit the number of recursions from action sets

2024-02-06 Thread Eric Dumazet via dev
On Tue, Feb 6, 2024 at 3:55 PM Aaron Conole wrote: > > > Oops - I didn't consider it. > > Given that, maybe the best approach would not to rely on per-cpu > counter. I'll respin in the next series with a depth counter that I pass > to the function instead and compare that. I guess that should

Re: [ovs-dev] [PATCH net 1/2] net: openvswitch: limit the number of recursions from action sets

2024-02-06 Thread Aaron Conole
Eric Dumazet writes: > On Tue, Feb 6, 2024 at 2:11 PM Aaron Conole wrote: >> >> The ovs module allows for some actions to recursively contain an action >> list for complex scenarios, such as sampling, checking lengths, etc. >> When these actions are copied into the internal flow table, they are

Re: [ovs-dev] [PATCH net 1/2] net: openvswitch: limit the number of recursions from action sets

2024-02-06 Thread Eric Dumazet via dev
On Tue, Feb 6, 2024 at 2:11 PM Aaron Conole wrote: > > The ovs module allows for some actions to recursively contain an action > list for complex scenarios, such as sampling, checking lengths, etc. > When these actions are copied into the internal flow table, they are > evaluated to validate that

[ovs-dev] [PATCH net 1/2] net: openvswitch: limit the number of recursions from action sets

2024-02-06 Thread Aaron Conole
The ovs module allows for some actions to recursively contain an action list for complex scenarios, such as sampling, checking lengths, etc. When these actions are copied into the internal flow table, they are evaluated to validate that such actions make sense, and these calls happen recursively.