Re: [ovs-dev] [PATCH net v3] net: openvswitch: fix to make sure flow_lookup() is not preempted

2020-10-17 Thread Eelco Chaudron
- Original Message - > From: "Jakub Kicinski" > To: "Eelco Chaudron" > Cc: net...@vger.kernel.org, da...@davemloft.net, d...@openvswitch.org, > pab...@redhat.com, pshe...@ovn.org, > jle...@redhat.com, bige...@linutronix.de, "i maximets" > Sent: Saturday, October 17, 2020 1:46:07 AM

Re: [ovs-dev] [PATCH net v3] net: openvswitch: fix to make sure flow_lookup() is not preempted

2020-10-16 Thread Jakub Kicinski
On Thu, 15 Oct 2020 19:09:33 +0200 Eelco Chaudron wrote: > The flow_lookup() function uses per CPU variables, which must be called > with BH disabled. However, this is fine in the general NAPI use case > where the local BH is disabled. But, it's also called from the netlink > context. The below

[ovs-dev] [PATCH net v3] net: openvswitch: fix to make sure flow_lookup() is not preempted

2020-10-15 Thread Eelco Chaudron
The flow_lookup() function uses per CPU variables, which must be called with BH disabled. However, this is fine in the general NAPI use case where the local BH is disabled. But, it's also called from the netlink context. The below patch makes sure that even in the netlink path, the BH is disabled.