Re: [ovs-dev] [PATCH ovn] automake.mk: Use PYTHON3 to generate the ovn-ic-{n, sb} pics

2020-02-18 Thread 0-day Robot
Bleep bloop. Greetings Timothy Redaelli, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: WARNING: Line is 121 characters long (recommended limit is 79) #36 FILE:

Re: [ovs-dev] [PATCH ovn] automake.mk: Use PYTHON3 to generate the ovn-ic-{n, sb} pics

2020-02-18 Thread Mark Michelson
Hi Timothy, It looks like some wires got crossed here. commit ff39e6c5 from James Page fixed this in master, but the fix was not backported to the 20.03 branch. I'm going to backport the existing commit to 20.03. On 2/18/20 12:53 PM, Timothy Redaelli wrote: Currently $(PYTHON) is used in

[ovs-dev] [PATCH ovn] automake.mk: Use PYTHON3 to generate the ovn-ic-{n, sb} pics

2020-02-18 Thread Timothy Redaelli
Currently $(PYTHON) is used in order to launch dot2pic script to generate the diagram, but this is wrong since PYTHON variable is NOT defined by the build system and so it fails when "python" binary doesn't exists (like on RHEL8). This commit fixes this by using the correct PYTHON3 variable that