Re: [ovs-dev] [PATCH ovn] call ovsrcu_exit() before exit in ovn-northd and ovn-controller to make valgrind happy

2023-06-14 Thread Igor Zhukov
I agree. Yes, we needed to check the build on version 22.03. Sorry. ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH ovn] call ovsrcu_exit() before exit in ovn-northd and ovn-controller to make valgrind happy

2023-06-14 Thread Dumitru Ceara
On 6/9/23 21:13, Mark Michelson wrote: > I pushed this change to main and all branches back to 22.03. Thanks! > Branch 22.03 doesn't have run_update_worker_pool() so this backport broke compilation there. I posted a 22.03-only revert patch:

Re: [ovs-dev] [PATCH ovn] call ovsrcu_exit() before exit in ovn-northd and ovn-controller to make valgrind happy

2023-06-09 Thread Igor Zhukov
Great! You are welcome! ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH ovn] call ovsrcu_exit() before exit in ovn-northd and ovn-controller to make valgrind happy

2023-06-09 Thread Mark Michelson
I pushed this change to main and all branches back to 22.03. Thanks! On 6/7/23 15:21, Mark Michelson wrote: Thanks, Igor. Acked-by: Mark Michelson On 6/6/23 20:37, Igor Zhukov wrote: From: Igor Zhukov You can check logs by running: make check-valgrind TESTSUITEFLAGS="246" (Actually

Re: [ovs-dev] [PATCH ovn] call ovsrcu_exit() before exit in ovn-northd and ovn-controller to make valgrind happy

2023-06-07 Thread Mark Michelson
Thanks, Igor. Acked-by: Mark Michelson On 6/6/23 20:37, Igor Zhukov wrote: From: Igor Zhukov You can check logs by running: make check-valgrind TESTSUITEFLAGS="246" (Actually almost every test affected but for example we need one test) Valgrind message looks like ==65437== 304 bytes in 1

[ovs-dev] [PATCH ovn] call ovsrcu_exit() before exit in ovn-northd and ovn-controller to make valgrind happy

2023-06-06 Thread Igor Zhukov
From: Igor Zhukov You can check logs by running: make check-valgrind TESTSUITEFLAGS="246" (Actually almost every test affected but for example we need one test) Valgrind message looks like ==65437== 304 bytes in 1 blocks are possibly lost in loss record 265 of 289 ==65437==at 0x483DD99: