Re: [ovs-dev] [PATCH ovn] controller: Store src_mac, src_ip in svc_monitor struct.

2024-05-22 Thread Vladislav Odintsov
Hi Ales! Thanks for the review. I've addressed requested changes in v2 with your Acked-by added: https://patchwork.ozlabs.org/project/ovn/patch/20240522121913.609332-1-odiv...@gmail.com/ regards, Vladislav Odintsov On 22.05.2024, 10:59, "dev on behalf of Ales Musil" wrote: On Tue, May

Re: [ovs-dev] [PATCH ovn] controller: Store src_mac, src_ip in svc_monitor struct.

2024-05-22 Thread Ales Musil
On Tue, May 14, 2024 at 9:25 PM Vladislav Odintsov wrote: > These structure members are read in pinctrl_handler() in a separare thread. > This is unsafe: when IDL is re-connected or some IDL objects are freed > after svc_monitors list with svc_monitor structures, which point to > sbrec_service_mo

Re: [ovs-dev] [PATCH ovn] controller: Store src_mac, src_ip in svc_monitor struct.

2024-05-14 Thread Vladislav Odintsov
Reported-at: https://mail.openvswitch.org/pipermail/ovs-dev/2024-April/413198.html > On 14 May 2024, at 22:25, Vladislav Odintsov wrote: > > These structure members are read in pinctrl_handler() in a separare thread. > This is unsafe: when IDL is re-connected or some IDL objects are freed > aft

[ovs-dev] [PATCH ovn] controller: Store src_mac, src_ip in svc_monitor struct.

2024-05-14 Thread Vladislav Odintsov
These structure members are read in pinctrl_handler() in a separare thread. This is unsafe: when IDL is re-connected or some IDL objects are freed after svc_monitors list with svc_monitor structures, which point to sbrec_service_monitor is initialized, sb_svc_mon structure property can point to wro