Re: [ovs-dev] [PATCH ovn] expr.c: Fix argument type of expr_write_scope().

2020-07-30 Thread Mark Michelson
Thanks, Han. I guess I need to upgrade gcc since I didn't see this locally. On 7/29/20 9:44 PM, Han Zhou wrote: There is compile error introduced by the commit 2054d01247. *** ../lib/expr.c:3328:6: error: symbol 'expr_type_check' redeclared with different type (originally declared at ../include

Re: [ovs-dev] [PATCH ovn] expr.c: Fix argument type of expr_write_scope().

2020-07-29 Thread Han Zhou
t;> > Acked-by: Ankur Sharma >> > >> > Regards, >> > Ankur >> >> Thanks Ankur, I applied this to master. >> >> > >> > From: dev on behalf of Han Zhou < >> hz...@ovn.org> >&

Re: [ovs-dev] [PATCH ovn] expr.c: Fix argument type of expr_write_scope().

2020-07-29 Thread Numan Siddique
, > > Ankur > > Thanks Ankur, I applied this to master. > > > > > From: dev on behalf of Han Zhou < > hz...@ovn.org> > > Sent: Wednesday, July 29, 2020 6:44 PM > > To: d...@openvswitch.org > > Cc: Han Zhou > > Subject: [ovs-dev] [PATCH ovn] exp

Re: [ovs-dev] [PATCH ovn] expr.c: Fix argument type of expr_write_scope().

2020-07-29 Thread Han Zhou
rg> > Sent: Wednesday, July 29, 2020 6:44 PM > To: d...@openvswitch.org > Cc: Han Zhou > Subject: [ovs-dev] [PATCH ovn] expr.c: Fix argument type of expr_write_scope(). > > There is compile error introduced by the commit 2054d01247. > *** > ../lib/expr.c:3328:6: e

Re: [ovs-dev] [PATCH ovn] expr.c: Fix argument type of expr_write_scope().

2020-07-29 Thread Ankur Sharma
Hi Han, Changes look fine. Acked-by: Ankur Sharma Regards, Ankur From: dev on behalf of Han Zhou Sent: Wednesday, July 29, 2020 6:44 PM To: d...@openvswitch.org Cc: Han Zhou Subject: [ovs-dev] [PATCH ovn] expr.c: Fix argument type of expr_write_scope

[ovs-dev] [PATCH ovn] expr.c: Fix argument type of expr_write_scope().

2020-07-29 Thread Han Zhou
There is compile error introduced by the commit 2054d01247. *** ../lib/expr.c:3328:6: error: symbol 'expr_type_check' redeclared with different type (originally declared at ../include/ovn/expr.h:481) - incompatible argument 4 (different signedness) Makefile:1971: recipe for target 'lib/expr.lo' fai