Re: [ovs-dev] [PATCH ovn] northd: Fix iteration over vip backends.

2020-12-06 Thread Numan Siddique
On Sat, Dec 5, 2020 at 1:10 AM Dumitru Ceara wrote: > > On 12/4/20 7:50 PM, Ilya Maximets wrote: > > During refactoring, direct access such as 'lb->vips[i].backends[j].op' > > was simplified by the presence of the 'backend_nb' pointer. But instead > > of the inner one, the index of the outer loop

Re: [ovs-dev] [PATCH ovn] northd: Fix iteration over vip backends.

2020-12-04 Thread Dumitru Ceara
On 12/4/20 7:50 PM, Ilya Maximets wrote: > During refactoring, direct access such as 'lb->vips[i].backends[j].op' > was simplified by the presence of the 'backend_nb' pointer. But instead > of the inner one, the index of the outer loop was used. This forces > northd to only use one backend per

[ovs-dev] [PATCH ovn] northd: Fix iteration over vip backends.

2020-12-04 Thread Ilya Maximets
During refactoring, direct access such as 'lb->vips[i].backends[j].op' was simplified by the presence of the 'backend_nb' pointer. But instead of the inner one, the index of the outer loop was used. This forces northd to only use one backend per vip, and can also lead to invalid memory accesses.