Re: [ovs-dev] [PATCH ovn] northd: Lookup route policy before ip routing

2023-07-27 Thread Dumitru Ceara
On 7/19/23 02:57, wangchuanlei wrote: > Hi, Dumitru, > > Thank you for reply and the suggestions! > Base on your suggestions, i have a thought below. Sorry for the late reply. > On 7/14/23 11:19, wangchuanlei wrote: >> Hi, Dumitru >> > >> Hi, wangchuanlei, > >> Thank you for review, i

Re: [ovs-dev] [PATCH ovn] northd: Lookup route policy before ip routing

2023-07-18 Thread wangchuanlei
Hi, Dumitru, Thank you for reply and the suggestions! Base on your suggestions, i have a thought below. On 7/14/23 11:19, wangchuanlei wrote: > Hi, Dumitru > > Hi, wangchuanlei, > Thank you for review, i don't have performance measurements yet. > In real physical switch, if flows hit

Re: [ovs-dev] [PATCH ovn] northd: Lookup route policy before ip routing

2023-07-14 Thread Dumitru Ceara
On 7/14/23 11:19, wangchuanlei wrote: > Hi, Dumitru > Hi, wangchuanlei, > Thank you for review, i don't have performance measurements yet. > In real physical switch, if flows hit dynimic/static route, or policy route, > the flows will skip other route entries, it's more reasonable on

Re: [ovs-dev] [PATCH ovn] northd: Lookup route policy before ip routing

2023-07-14 Thread wangchuanlei
Hi, Dumitru Thank you for review, i don't have performance measurements yet. In real physical switch, if flows hit dynimic/static route, or policy route, the flows will skip other route entries, it's more reasonable on logic. For ovn, in table of ip route, there is no default route entry

Re: [ovs-dev] [PATCH ovn] northd: Lookup route policy before ip routing

2023-07-12 Thread Dumitru Ceara
Hi wangchuanlei, Thanks for the patch! On 7/10/23 10:46, wangchuanlei wrote: > If there is no route in table ip_routing, the route policy > item in table policy is useless. I'm sorry but I disagree with this. We can always add a default route that matches all traffic that's not matched by

[ovs-dev] [PATCH ovn] northd: Lookup route policy before ip routing

2023-07-10 Thread wangchuanlei
If there is no route in table ip_routing, the route policy item in table policy is useless. Because route policy has a higher priority than ip routing, so moddify the table id of IP_ROUTING and POLICY is a little better.By this way, there is no need reroute any more, this should be more

Re: [ovs-dev] [PATCH ovn] northd: Lookup route policy before ip routing

2023-06-20 Thread 0-day Robot
Bleep bloop. Greetings wangchuanlei, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: WARNING: Line is 101 characters long (recommended limit is 79) #50 FILE: northd/northd.c:345:

[ovs-dev] [PATCH ovn] northd: Lookup route policy before ip routing

2023-06-20 Thread wangchuanlei
If there is no route in table ip_routing, the route policy item in table policy is useless. Because route policy has a higher priority than ip routing, so modify the table id of IP_ROUTING and POLICY is a little better.By this way, there is no need reroute any more, this should be more