Re: [ovs-dev] [PATCH ovn] ovn-ctl: Add option to skip schema conversion

2024-01-10 Thread Frode Nordahl
On Wed, Jan 10, 2024 at 2:05 PM Martin Kalcok wrote: > > ovn-ctl script currently automatically attempts to perform clustered > database schema upgrade when starting OVN SB or NB clustered > database. To provide more controll over this procees a See nit from v1. > `--db-cluster-schema-upgrade`

Re: [ovs-dev] [PATCH ovn] ovn-ctl: Add option to skip schema conversion

2024-01-10 Thread 0-day Robot
Bleep bloop. Greetings Martin Kalcok, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: WARNING: Line is 99 characters long (recommended limit is 79) #92 FILE:

[ovs-dev] [PATCH ovn] ovn-ctl: Add option to skip schema conversion

2024-01-10 Thread Martin Kalcok
ovn-ctl script currently automatically attempts to perform clustered database schema upgrade when starting OVN SB or NB clustered database. To provide more controll over this procees a `--db-cluster-schema-upgrade` option is added. Default value for this option is `yes`, to preserve current

Re: [ovs-dev] [PATCH ovn] ovn-ctl: Add option to skip schema conversion

2024-01-10 Thread martin . kalcok
On Tue, 2024-01-09 at 08:23 +0100, Frode Nordahl wrote: > Hello, Martin, > > Thank you for working on this! > > While the automatic conversion is nice when it works, it is a source > of problems when it does not, so I welcome this change. > > An additional argument for this change is that the

Re: [ovs-dev] [PATCH ovn] ovn-ctl: Add option to skip schema conversion

2024-01-08 Thread Frode Nordahl
Hello, Martin, Thank you for working on this! While the automatic conversion is nice when it works, it is a source of problems when it does not, so I welcome this change. An additional argument for this change is that the existing approach executes asynchronously, so there is no way for the

Re: [ovs-dev] [PATCH ovn] ovn-ctl: Add option to skip schema conversion

2024-01-08 Thread 0-day Robot
Bleep bloop. Greetings Martin Kalcok, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: WARNING: Line is 99 characters long (recommended limit is 79) #89 FILE:

[ovs-dev] [PATCH ovn] ovn-ctl: Add option to skip schema conversion

2024-01-08 Thread Martin Kalcok
ovn-ctl script currently automatically attempts to perform clustered database schema upgrade when starting OVN SB or NB clustered database. To provide more controll over this procees a `--db-cluster-skip-upgrade` option is added that allows skipping the upgrade. Default value for this option is