Re: [ovs-dev] [PATCH ovn] ovn-northd: Don't log transaction failures on standby instances.

2022-02-23 Thread Dumitru Ceara
On 2/23/22 19:50, Han Zhou wrote: > On Wed, Feb 23, 2022 at 12:35 AM Dumitru Ceara wrote: >> >> On 2/23/22 09:24, Dumitru Ceara wrote: >>> On 2/23/22 07:27, Han Zhou wrote: On Fri, Feb 11, 2022 at 12:52 AM Dumitru Ceara > wrote: > > On 2/11/22 00:54, Numan Siddique wrote: >> On

Re: [ovs-dev] [PATCH ovn] ovn-northd: Don't log transaction failures on standby instances.

2022-02-23 Thread Han Zhou
On Wed, Feb 23, 2022 at 12:35 AM Dumitru Ceara wrote: > > On 2/23/22 09:24, Dumitru Ceara wrote: > > On 2/23/22 07:27, Han Zhou wrote: > >> On Fri, Feb 11, 2022 at 12:52 AM Dumitru Ceara wrote: > >>> > >>> On 2/11/22 00:54, Numan Siddique wrote: > On Thu, Jan 27, 2022 at 10:00 AM Dumitru

Re: [ovs-dev] [PATCH ovn] ovn-northd: Don't log transaction failures on standby instances.

2022-02-23 Thread Dumitru Ceara
On 2/23/22 09:24, Dumitru Ceara wrote: > On 2/23/22 07:27, Han Zhou wrote: >> On Fri, Feb 11, 2022 at 12:52 AM Dumitru Ceara wrote: >>> >>> On 2/11/22 00:54, Numan Siddique wrote: On Thu, Jan 27, 2022 at 10:00 AM Dumitru Ceara >> wrote: > > We still need to try to

Re: [ovs-dev] [PATCH ovn] ovn-northd: Don't log transaction failures on standby instances.

2022-02-23 Thread Dumitru Ceara
On 2/23/22 07:27, Han Zhou wrote: > On Fri, Feb 11, 2022 at 12:52 AM Dumitru Ceara wrote: >> >> On 2/11/22 00:54, Numan Siddique wrote: >>> On Thu, Jan 27, 2022 at 10:00 AM Dumitru Ceara > wrote: We still need to try to ovsdb_idl_loop_commit_and_wait() on instances that are in

Re: [ovs-dev] [PATCH ovn] ovn-northd: Don't log transaction failures on standby instances.

2022-02-22 Thread Han Zhou
On Fri, Feb 11, 2022 at 12:52 AM Dumitru Ceara wrote: > > On 2/11/22 00:54, Numan Siddique wrote: > > On Thu, Jan 27, 2022 at 10:00 AM Dumitru Ceara wrote: > >> > >> We still need to try to ovsdb_idl_loop_commit_and_wait() on instances > >> that are in standby mode. That's because they need to

Re: [ovs-dev] [PATCH ovn] ovn-northd: Don't log transaction failures on standby instances.

2022-02-11 Thread Numan Siddique
On Fri, Feb 11, 2022 at 3:53 AM Dumitru Ceara wrote: > > On 2/11/22 00:54, Numan Siddique wrote: > > On Thu, Jan 27, 2022 at 10:00 AM Dumitru Ceara wrote: > >> > >> We still need to try to ovsdb_idl_loop_commit_and_wait() on instances > >> that are in standby mode. That's because they need to

Re: [ovs-dev] [PATCH ovn] ovn-northd: Don't log transaction failures on standby instances.

2022-02-11 Thread Dumitru Ceara
On 2/11/22 00:54, Numan Siddique wrote: > On Thu, Jan 27, 2022 at 10:00 AM Dumitru Ceara wrote: >> >> We still need to try to ovsdb_idl_loop_commit_and_wait() on instances >> that are in standby mode. That's because they need to try to take the >> lock. But if they're in standby they won't

Re: [ovs-dev] [PATCH ovn] ovn-northd: Don't log transaction failures on standby instances.

2022-02-10 Thread Numan Siddique
On Thu, Jan 27, 2022 at 10:00 AM Dumitru Ceara wrote: > > We still need to try to ovsdb_idl_loop_commit_and_wait() on instances > that are in standby mode. That's because they need to try to take the > lock. But if they're in standby they won't actually build a transaction > json and will

[ovs-dev] [PATCH ovn] ovn-northd: Don't log transaction failures on standby instances.

2022-01-27 Thread Dumitru Ceara
We still need to try to ovsdb_idl_loop_commit_and_wait() on instances that are in standby mode. That's because they need to try to take the lock. But if they're in standby they won't actually build a transaction json and will return early because they don't own the SB lock. That's reported as