Re: [ovs-dev] [PATCH ovn] ovn-northd: Fix update of a mac prefix.

2021-09-13 Thread Mark Michelson
Thanks, I backported this to branch-21.03 and branch-21.06. On 9/13/21 2:32 PM, Ilya Maximets wrote: On 9/13/21 20:29, Mark Michelson wrote: I merged this to master. Should this be backported as well? Setting options:mac_prefix="00:00:00:00:00:00" triggers infinite mac changes on all dynamic

Re: [ovs-dev] [PATCH ovn] ovn-northd: Fix update of a mac prefix.

2021-09-13 Thread Ilya Maximets
On 9/13/21 20:29, Mark Michelson wrote: > I merged this to master. Should this be backported as well? Setting options:mac_prefix="00:00:00:00:00:00" triggers infinite mac changes on all dynamic ports, so IMO this could be considered as a bug fix suitable for backporting. Best regards, Ilya

Re: [ovs-dev] [PATCH ovn] ovn-northd: Fix update of a mac prefix.

2021-09-13 Thread Mark Michelson
I merged this to master. Should this be backported as well? On 9/9/21 6:31 AM, Mark Gray wrote: On 08/09/2021 13:16, Ilya Maximets wrote: 'smap_add' doesn't check for duplicates. This leads to having more than one entry with a 'mac_prefix' key in the 'options' smap. 'ovsdb_datum_sort_unique'

Re: [ovs-dev] [PATCH ovn] ovn-northd: Fix update of a mac prefix.

2021-09-09 Thread Mark Gray
On 08/09/2021 13:16, Ilya Maximets wrote: > 'smap_add' doesn't check for duplicates. This leads to having > more than one entry with a 'mac_prefix' key in the 'options' smap. > > 'ovsdb_datum_sort_unique' removes duplicates before sending the > transaction. It does that by sorting values and

[ovs-dev] [PATCH ovn] ovn-northd: Fix update of a mac prefix.

2021-09-08 Thread Ilya Maximets
'smap_add' doesn't check for duplicates. This leads to having more than one entry with a 'mac_prefix' key in the 'options' smap. 'ovsdb_datum_sort_unique' removes duplicates before sending the transaction. It does that by sorting values and keeping the first one per key. In normal case