Re: [ovs-dev] [PATCH ovn 00/15] Fixed another set of flaky Unit Tests

2023-10-23 Thread Xavier Simonart
Hi Mark, Dumitru Thanks for the feedback On Fri, Oct 6, 2023 at 12:57 PM Dumitru Ceara wrote: > > On 10/6/23 09:08, Dumitru Ceara wrote: > > Hi Xavier, Mark, > > > > On 9/21/23 15:27, Xavier Simonart wrote: > >> Hi Mark > >> > >> Thanks for the review. See comments below. > >> Thanks > >>

Re: [ovs-dev] [PATCH ovn 00/15] Fixed another set of flaky Unit Tests

2023-10-06 Thread Dumitru Ceara
On 10/6/23 09:08, Dumitru Ceara wrote: > Hi Xavier, Mark, > > On 9/21/23 15:27, Xavier Simonart wrote: >> Hi Mark >> >> Thanks for the review. See comments below. >> Thanks >> Xavier >> >> >> On Tue, Sep 19, 2023 at 5:29 PM Mark Michelson wrote: >> >>> Thanks for the patch set Xavier. >>> >>>

Re: [ovs-dev] [PATCH ovn 00/15] Fixed another set of flaky Unit Tests

2023-10-06 Thread Dumitru Ceara
Hi Xavier, Mark, On 9/21/23 15:27, Xavier Simonart wrote: > Hi Mark > > Thanks for the review. See comments below. > Thanks > Xavier > > > On Tue, Sep 19, 2023 at 5:29 PM Mark Michelson wrote: > >> Thanks for the patch set Xavier. >> >> With the exception of patch 13: >> >> Acked-by: Mark

Re: [ovs-dev] [PATCH ovn 00/15] Fixed another set of flaky Unit Tests

2023-09-21 Thread Xavier Simonart
Hi Mark Thanks for the review. See comments below. Thanks Xavier On Tue, Sep 19, 2023 at 5:29 PM Mark Michelson wrote: > Thanks for the patch set Xavier. > > With the exception of patch 13: > > Acked-by: Mark Michelson > > I'm acking the patch set, but the nature of these changes worries me.

Re: [ovs-dev] [PATCH ovn 00/15] Fixed another set of flaky Unit Tests

2023-09-19 Thread Mark Michelson
Thanks for the patch set Xavier. With the exception of patch 13: Acked-by: Mark Michelson I'm acking the patch set, but the nature of these changes worries me. I could easily see another patch series like this needed in the future because it's too easy to write flaky tests. Here are some

[ovs-dev] [PATCH ovn 00/15] Fixed another set of flaky Unit Tests

2023-09-18 Thread Xavier Simonart
Xavier Simonart (15): tests: fixed multiple ovn-ic tests tests: fixed "Logical router policy packet marking" tests: fixed "options:requested-chassis for logical port" tests: tests fixed "Encaps tunnel cleanup ..." and "ovn-controller exit" tests: wait for all flows to be installed