subject:"\[ovs\-dev\] \[PATCH ovn 01\/12\] tests\: Improve \"dhcpv4 \: 1 HV, 2 LS, 2 LSPs\/LS\"."

Re: [ovs-dev] [PATCH ovn 01/12] tests: Improve "dhcpv4 : 1 HV, 2 LS, 2 LSPs/LS".

2020-11-04 Thread Ben Pfaff

On Wed, Nov 04, 2020 at 03:36:20PM +0530, Numan Siddique wrote: > On Wed, Nov 4, 2020 at 12:33 PM Ben Pfaff wrote: > > > > This change makes the test much more debuggable: > > > > - Make it easier to find the particular failing test. > > > > - Use correct checksums so that the packets can be compa

Re: [ovs-dev] [PATCH ovn 01/12] tests: Improve "dhcpv4 : 1 HV, 2 LS, 2 LSPs/LS".

2020-11-04 Thread Numan Siddique

On Wed, Nov 4, 2020 at 12:33 PM Ben Pfaff wrote: > > This change makes the test much more debuggable: > > - Make it easier to find the particular failing test. > > - Use correct checksums so that the packets can be compared for > equality instead of omitting the checksum field. > > - Factor out

[ovs-dev] [PATCH ovn 01/12] tests: Improve "dhcpv4 : 1 HV, 2 LS, 2 LSPs/LS".

2020-11-03 Thread Ben Pfaff

This change makes the test much more debuggable: - Make it easier to find the particular failing test. - Use correct checksums so that the packets can be compared for equality instead of omitting the checksum field. - Factor out packet comparison and produce better error messages on failure.