Re: [ovs-dev] [PATCH ovn 10/12] Export `VLOG_WARN` and `VLOG_ERR` from libovn for use in ddlog

2020-11-04 Thread Ben Pfaff
On Wed, Nov 04, 2020 at 11:20:31PM +0530, Numan Siddique wrote: > On Wed, Nov 4, 2020 at 12:34 PM Ben Pfaff wrote: > > > > From: Leonid Ryzhyk > > > > Export `ddlog_warn` and `ddlog_err` functions that are just wrappers > > around `VLOG_WARN` and `VLOG_ERR`. This is not ideal because the > >

Re: [ovs-dev] [PATCH ovn 10/12] Export `VLOG_WARN` and `VLOG_ERR` from libovn for use in ddlog

2020-11-04 Thread Numan Siddique
On Wed, Nov 4, 2020 at 12:34 PM Ben Pfaff wrote: > > From: Leonid Ryzhyk > > Export `ddlog_warn` and `ddlog_err` functions that are just wrappers > around `VLOG_WARN` and `VLOG_ERR`. This is not ideal because the > functions are exported by `ovn_util.c` and the resulting log messages use >

Re: [ovs-dev] [PATCH ovn 10/12] Export `VLOG_WARN` and `VLOG_ERR` from libovn for use in ddlog

2020-11-04 Thread 0-day Robot
Bleep bloop. Greetings Ben Pfaff, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: WARNING: Unexpected sign-offs from developers who are not authors or co-authors or committers:

[ovs-dev] [PATCH ovn 10/12] Export `VLOG_WARN` and `VLOG_ERR` from libovn for use in ddlog

2020-11-03 Thread Ben Pfaff
From: Leonid Ryzhyk Export `ddlog_warn` and `ddlog_err` functions that are just wrappers around `VLOG_WARN` and `VLOG_ERR`. This is not ideal because the functions are exported by `ovn_util.c` and the resulting log messages use `ovn_util` as module name. More importantly, these functions do