Re: [ovs-dev] [PATCH ovn 13/15] tests: fixed "LSP incremental processing"

2023-09-20 Thread Xavier Simonart
Hi Mark Thanks for the review and the comments. I was initially afraid of more notifications received within the same transactions causing even less recomputes (hence the -le). However, after a second look I think we can only receive 4 or 5 recomputes in this scenario (1 for lsp added by nb, 1

Re: [ovs-dev] [PATCH ovn 13/15] tests: fixed "LSP incremental processing"

2023-09-19 Thread Mark Michelson
Of the 15 patches in this set, this is the only one that I disagree with. The problem with this change is that the test writer likely has a specific amount of recomputes they expect to see based on the changes that are applied. With the "-le" change, it means that the test could pass in a

[ovs-dev] [PATCH ovn 13/15] tests: fixed "LSP incremental processing"

2023-09-18 Thread Xavier Simonart
We might get less recomputes than expected: e.g. Port_Binding->chassis and Port_Binding->up might be received by northd within the same idl transaction. Signed-off-by: Xavier Simonart --- tests/ovn-northd.at | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git