Re: [ovs-dev] [PATCH ovn branch-22.12] northd: Make sure that skip_snat=true is evaluated before force_snat

2023-08-30 Thread Dumitru Ceara
On 8/30/23 13:10, Ales Musil wrote: > The affinity code was differentiating between force_snat > and skip snat. However, if both parameters were set at the > same time the force_snat would be preferred, which shouldn't > be the case. > > Make sure the skip_snat is preferred if both parameters are

Re: [ovs-dev] [PATCH ovn branch-22.12] northd: Make sure that skip_snat=true is evaluated before force_snat

2023-08-30 Thread 0-day Robot
Bleep bloop. Greetings Ales Musil, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: ERROR: "Fixes" tag is malformed. Use the following format: git log -1 --pretty=format:"Fixes:

[ovs-dev] [PATCH ovn branch-22.12] northd: Make sure that skip_snat=true is evaluated before force_snat

2023-08-30 Thread Ales Musil
The affinity code was differentiating between force_snat and skip snat. However, if both parameters were set at the same time the force_snat would be preferred, which shouldn't be the case. Make sure the skip_snat is preferred if both parameters are present. Fixes: d3926b4 ("northd: rely on new