Re: [ovs-dev] [PATCH ovn v1] test/ovstest: fix shared library deps.

2020-05-18 Thread aginwala
Thanks Numan for review and merge. Yup, I thought the same at first. Going further, let's make sure new patches pass CI as a prereq before merging. On Mon, May 18, 2020 at 2:06 AM Numan Siddique wrote: > On Mon, May 18, 2020 at 1:37 PM wrote: > > > From: Aliasgar Ginwala > > > > When using

Re: [ovs-dev] [PATCH ovn v1] test/ovstest: fix shared library deps.

2020-05-18 Thread Numan Siddique
On Mon, May 18, 2020 at 1:37 PM wrote: > From: Aliasgar Ginwala > > When using --enable-shared for configure, make fails with error > lib/.libs/libovn.so: undefined reference to `set_pidfile' > collect2: error: ld returned 1 exit status > Makefile:1616: recipe for target 'tests/ovstest' failed

[ovs-dev] [PATCH ovn v1] test/ovstest: fix shared library deps.

2020-05-18 Thread amginwal
From: Aliasgar Ginwala When using --enable-shared for configure, make fails with error lib/.libs/libovn.so: undefined reference to `set_pidfile' collect2: error: ld returned 1 exit status Makefile:1616: recipe for target 'tests/ovstest' failed make[1]: *** [tests/ovstest] Error 1 make[1]: