Re: [ovs-dev] [PATCH ovn v2] Fix the routing for external logical ports of bridged logical switches.

2020-08-19 Thread Numan Siddique
On Thu, Aug 13, 2020 at 4:20 PM Dumitru Ceara wrote: > > On 8/6/20 9:57 AM, Numan Siddique wrote: > > Thanks Ankur for the lengthy reply. > > > > Please see below for some comments. > > > > Thanks > > Numan > > > > > > On Thu, Jul 30, 2020 at 9:23 AM Ankur Sharma > > wrote: > > > >> Hi Numan,

Re: [ovs-dev] [PATCH ovn v2] Fix the routing for external logical ports of bridged logical switches.

2020-08-13 Thread Dumitru Ceara
On 8/6/20 9:57 AM, Numan Siddique wrote: > Thanks Ankur for the lengthy reply. > > Please see below for some comments. > > Thanks > Numan > > > On Thu, Jul 30, 2020 at 9:23 AM Ankur Sharma > wrote: > >> Hi Numan, Daniel, Lucas, >> >> Thank you so much for the feedback and providing your

Re: [ovs-dev] [PATCH ovn v2] Fix the routing for external logical ports of bridged logical switches.

2020-08-06 Thread Numan Siddique
Thanks Ankur for the lengthy reply. Please see below for some comments. Thanks Numan On Thu, Jul 30, 2020 at 9:23 AM Ankur Sharma wrote: > Hi Numan, Daniel, Lucas, > > Thank you so much for the feedback and providing your inputs. > I went the through the bug that was being referenced and

Re: [ovs-dev] [PATCH ovn v2] Fix the routing for external logical ports of bridged logical switches.

2020-07-29 Thread Ankur Sharma
Hi Numan, Daniel, Lucas, ThankĀ  you so much for the feedback and providing your inputs. I went the through the bug that was being referenced and Numan's inputs and following is my take on it. Its a lengthy email, if you just want to look at the suggestions for fix then please scroll to the

Re: [ovs-dev] [PATCH ovn v2] Fix the routing for external logical ports of bridged logical switches.

2020-07-25 Thread Ankur Sharma
Hi Numan, Sorry, was a little out of sync with mailing list this week. I will get back to you sometime early next week. But yes, using chassis mac for router port ip is not correct ?. Let me check the scenario you have called out and will try to propose alternatives. Regards, Ankur

Re: [ovs-dev] [PATCH ovn v2] Fix the routing for external logical ports of bridged logical switches.

2020-07-22 Thread Numan Siddique
On Mon, Jul 13, 2020 at 11:56 AM Numan Siddique wrote: > +Daniel Alvarez Sanchez > +Lucas Alvares Gomes Martins > > > On Mon, Jul 13, 2020 at 11:29 AM Ankur Sharma > wrote: > >> Hi Numan, >> >> Thank you so much for the details. >> >> > Hi Ankur, > > Thanks for the detailed email. Your

Re: [ovs-dev] [PATCH ovn v2] Fix the routing for external logical ports of bridged logical switches.

2020-07-13 Thread Numan Siddique
+Daniel Alvarez Sanchez +Lucas Alvares Gomes Martins On Mon, Jul 13, 2020 at 11:29 AM Ankur Sharma wrote: > Hi Numan, > > Thank you so much for the details. > > Hi Ankur, Thanks for the detailed email. Your analysis is correct. I have few comments. Please see below. > Following is my

Re: [ovs-dev] [PATCH ovn v2] Fix the routing for external logical ports of bridged logical switches.

2020-07-12 Thread Ankur Sharma
Hi Numan, Thank you so much for the details. Following is my analysis on the feature: a. Port of type EXTERNAL means that we create a logical switch port in OVN without a VIF backing. b. i.e the physical port corresponding to external port is NOT behind OVN managed vswitch (for SRIOV specific

Re: [ovs-dev] [PATCH ovn v2] Fix the routing for external logical ports of bridged logical switches.

2020-07-10 Thread Numan Siddique
On Fri, Jul 10, 2020 at 4:41 PM Numan Siddique wrote: > > > On Fri, Jul 10, 2020 at 12:45 AM Ankur Sharma > wrote: > >> Hi Numan, Daniel, >> >> I have not looked at the patch yet. But replacing arp.sha with chassis >> mac is not the correct approach from networking perspective. >> Chassic mac

Re: [ovs-dev] [PATCH ovn v2] Fix the routing for external logical ports of bridged logical switches.

2020-07-10 Thread Numan Siddique
On Fri, Jul 10, 2020 at 12:45 AM Ankur Sharma wrote: > Hi Numan, Daniel, > > I have not looked at the patch yet. But replacing arp.sha with chassis mac > is not the correct approach from networking perspective. > Chassic mac is NOT meant to replace the IP-MAC binding of router port, it > is ONLY

Re: [ovs-dev] [PATCH ovn v2] Fix the routing for external logical ports of bridged logical switches.

2020-07-09 Thread Ankur Sharma
Hi Numan, Daniel, I have not looked at the patch yet. But replacing arp.sha with chassis mac is not the correct approach from networking perspective. Chassic mac is NOT meant to replace the IP-MAC binding of router port, it is ONLY meant to ensure that for EW traffic a distributed router port

[ovs-dev] [PATCH ovn v2] Fix the routing for external logical ports of bridged logical switches.

2020-07-09 Thread numans
From: Numan Siddique Routing for external logical ports is broken if these ports belonged to bridged logical switches (with localnet port) and 'ovn-chassis-mac-mappings' is configured. External logical ports are those which are external to OVN, but there is a logical port for it and it is