Re: [ovs-dev] [PATCH ovn v2] northd, controller: Commit flows dropped by ACLs to conntrack

2023-04-03 Thread Numan Siddique
On Mon, Apr 3, 2023 at 5:55 AM Dumitru Ceara wrote: > > On 4/3/23 11:47, Abhiram Sangana wrote: > > > > > >> On 29 Mar 2023, at 16:21, Dumitru Ceara wrote: > >> > >> On 3/29/23 12:00, Abhiram Sangana wrote: > >> @@ -896,6 +904,26 @@ put_local_common_flows(uint32_t dp_key, > >>

Re: [ovs-dev] [PATCH ovn v2] northd, controller: Commit flows dropped by ACLs to conntrack

2023-04-03 Thread Dumitru Ceara
On 4/3/23 11:47, Abhiram Sangana wrote: > > >> On 29 Mar 2023, at 16:21, Dumitru Ceara wrote: >> >> On 3/29/23 12:00, Abhiram Sangana wrote: >> @@ -896,6 +904,26 @@ put_local_common_flows(uint32_t dp_key, >>pb->header_.uuid.parts[0], , ofpacts_p, >>

Re: [ovs-dev] [PATCH ovn v2] northd, controller: Commit flows dropped by ACLs to conntrack

2023-04-03 Thread Abhiram Sangana
> On 29 Mar 2023, at 16:21, Dumitru Ceara wrote: > > On 3/29/23 12:00, Abhiram Sangana wrote: > @@ -896,6 +904,26 @@ put_local_common_flows(uint32_t dp_key, >pb->header_.uuid.parts[0], , ofpacts_p, >>header_.uuid); > > +if

Re: [ovs-dev] [PATCH ovn v2] northd, controller: Commit flows dropped by ACLs to conntrack

2023-03-29 Thread Dumitru Ceara
On 3/29/23 12:00, Abhiram Sangana wrote: @@ -896,6 +904,26 @@ put_local_common_flows(uint32_t dp_key, pb->header_.uuid.parts[0], , ofpacts_p, >header_.uuid); +if (zone_ids->drop) { +/* Table 39, Priority 1. +

Re: [ovs-dev] [PATCH ovn v2] northd, controller: Commit flows dropped by ACLs to conntrack

2023-03-29 Thread Abhiram Sangana
Hi Dumitru, Thanks for reviewing the patch. > On 23 Mar 2023, at 20:59, Dumitru Ceara wrote: > > On 3/17/23 20:34, Numan Siddique wrote: >> On Mon, Feb 13, 2023 at 11:36 AM Abhiram Sangana >> wrote: >>> >>> This patch adds support to commit connections dropped/rejected by >>> ACLs to the

Re: [ovs-dev] [PATCH ovn v2] northd, controller: Commit flows dropped by ACLs to conntrack

2023-03-23 Thread Dumitru Ceara
On 3/17/23 20:34, Numan Siddique wrote: > On Mon, Feb 13, 2023 at 11:36 AM Abhiram Sangana > wrote: >> >> This patch adds support to commit connections dropped/rejected by >> ACLs to the connection tracking table. Dropped connections are >> committed to conntrack only if NB_Global

Re: [ovs-dev] [PATCH ovn v2] northd, controller: Commit flows dropped by ACLs to conntrack

2023-03-21 Thread Abhiram Sangana
> On 18 Mar 2023, at 01:04, Numan Siddique wrote: > > On Mon, Feb 13, 2023 at 11:36 AM Abhiram Sangana > wrote: >> >> This patch adds support to commit connections dropped/rejected by >> ACLs to the connection tracking table. Dropped connections are >> committed to conntrack only if

Re: [ovs-dev] [PATCH ovn v2] northd, controller: Commit flows dropped by ACLs to conntrack

2023-03-17 Thread Numan Siddique
On Mon, Feb 13, 2023 at 11:36 AM Abhiram Sangana wrote: > > This patch adds support to commit connections dropped/rejected by > ACLs to the connection tracking table. Dropped connections are > committed to conntrack only if NB_Global options:ct_commit_acl_drop > is set to true (false by default)

Re: [ovs-dev] [PATCH ovn v2] northd, controller: Commit flows dropped by ACLs to conntrack

2023-03-17 Thread Dumitru Ceara
On 3/3/23 13:20, Abhiram Sangana wrote: > > >> On 13 Feb 2023, at 16:35, Abhiram Sangana >> wrote: >> >> This patch adds support to commit connections dropped/rejected by >> ACLs to the connection tracking table. Dropped connections are >> committed to conntrack only if NB_Global

Re: [ovs-dev] [PATCH ovn v2] northd, controller: Commit flows dropped by ACLs to conntrack

2023-03-03 Thread Abhiram Sangana
> On 13 Feb 2023, at 16:35, Abhiram Sangana wrote: > > This patch adds support to commit connections dropped/rejected by > ACLs to the connection tracking table. Dropped connections are > committed to conntrack only if NB_Global options:ct_commit_acl_drop > is set to true (false by default)

Re: [ovs-dev] [PATCH ovn v2] northd, controller: Commit flows dropped by ACLs to conntrack

2023-02-13 Thread 0-day Robot
References: <20230213163539.4507-1-sangana.abhi...@nutanix.com> Bleep bloop. Greetings Abhiram Sangana, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: WARNING: Line is 82

[ovs-dev] [PATCH ovn v2] northd, controller: Commit flows dropped by ACLs to conntrack

2023-02-13 Thread Abhiram Sangana
This patch adds support to commit connections dropped/rejected by ACLs to the connection tracking table. Dropped connections are committed to conntrack only if NB_Global options:ct_commit_acl_drop is set to true (false by default) and ACL dropping/rejecting the connection has label configured. The