Re: [ovs-dev] [PATCH ovn v2 2/2] ofctrl: Prevent conjunction duplication

2023-09-11 Thread Dumitru Ceara
On 9/6/23 16:39, Mark Michelson wrote: > Thanks Ales, > Hi Ales, Mark, > Acked-by: Mark Michelson > > Thankfully the extra overhead is in the much less frequently-hit case. > We still do a O(N^2) processing, I wonder if it's a lot of work/complexity to add the map to all 'struct desired_flow

Re: [ovs-dev] [PATCH ovn v2 2/2] ofctrl: Prevent conjunction duplication

2023-09-06 Thread Mark Michelson
Thanks Ales, Acked-by: Mark Michelson Thankfully the extra overhead is in the much less frequently-hit case. On 8/29/23 04:47, Ales Musil wrote: During ofctrl_add_or_append_flow we are able to combine two flows with same match but different conjunctions. However, the function didn't check if

[ovs-dev] [PATCH ovn v2 2/2] ofctrl: Prevent conjunction duplication

2023-08-29 Thread Ales Musil
During ofctrl_add_or_append_flow we are able to combine two flows with same match but different conjunctions. However, the function didn't check if the conjunctions already exist in the installed flow, which could result in conjunction duplication and the flow would grow infinitely e.g. actions=con