Re: [ovs-dev] [PATCH ovn v3] controller: Avoid double controller action for ICMP errors.

2024-03-15 Thread Mark Michelson
On 2/12/24 07:00, Dumitru Ceara wrote: On 2/6/24 10:15, Ales Musil wrote: The fields that are not directly supported by OvS were encoded via additional controller action that changed the required value. This was most notably needed for ICMP need frag messages. Encode the field value loads as

Re: [ovs-dev] [PATCH ovn v3] controller: Avoid double controller action for ICMP errors.

2024-02-12 Thread Dumitru Ceara
On 2/6/24 10:15, Ales Musil wrote: > The fields that are not directly supported by OvS were encoded > via additional controller action that changed the required value. > This was most notably needed for ICMP need frag messages. > > Encode the field value loads as note action instead. This allows

Re: [ovs-dev] [PATCH ovn v3] controller: Avoid double controller action for ICMP errors.

2024-02-06 Thread 0-day Robot
Bleep bloop. Greetings Ales Musil, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: WARNING: Comment with 'xxx' marker #241 FILE: controller/pinctrl.c:6422: /* XXX: This handler

[ovs-dev] [PATCH ovn v3] controller: Avoid double controller action for ICMP errors.

2024-02-06 Thread Ales Musil
The fields that are not directly supported by OvS were encoded via additional controller action that changed the required value. This was most notably needed for ICMP need frag messages. Encode the field value loads as note action instead. This allows us to find the note and act accordingly in